revert to QFile::remove to remove single files - #8195
Merged
Conversation
mgallien
requested review from
camilasan,
claucambra and
nilsding
as code owners
April 24, 2025 08:26
mgallien
force-pushed
the
bugfix/useQFileAgain
branch
from
April 24, 2025 08:28
fb631c5 to
d4f2e19
Compare
This reverts commit 58d28ab. Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
this API has a way to provide an error when failing to delete a folder we may want to know why teh folderf ailed to be deleted QDir::rmdir does not provide any error when failing to delete a folder Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/useQFileAgain
branch
from
April 24, 2025 08:29
d4f2e19 to
0eacdce
Compare
Collaborator
Author
|
/backport to stable-3.16 |
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-8195.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
nilsding
approved these changes
Apr 24, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revert to QFile::remove to remove a single file
still use std::filesystem::remove to remove a single empty folder
QDir::rmdir does not provide any error message when failing to delete a folder