Skip to content

[stable-3.16] revert to QFile::remove to remove single files - #8198

Merged
mgallien merged 3 commits into
stable-3.16from
backport/8195/stable-3.16
Apr 24, 2025
Merged

[stable-3.16] revert to QFile::remove to remove single files#8198
mgallien merged 3 commits into
stable-3.16from
backport/8195/stable-3.16

Conversation

@backportbot

@backportbot backportbot Bot commented Apr 24, 2025

Copy link
Copy Markdown

Backport of PR #8195

This reverts commit 58d28ab.

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
this API has a way to provide an error when failing to delete a folder

we may want to know why teh folderf ailed to be deleted

QDir::rmdir does not provide any error when failing to delete a folder

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@backportbot
backportbot Bot requested review from mgallien and nilsding April 24, 2025 09:18
@backportbot backportbot Bot added this to the 3.16.4 milestone Apr 24, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-8198.zip

SHA256 checksum: 5e76bd1449c21caab98fc8a62a7d7faa53143f0b2a93cdfd67a15d4211bd1208

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien
mgallien merged commit 0588b9f into stable-3.16 Apr 24, 2025
@mgallien
mgallien deleted the backport/8195/stable-3.16 branch April 24, 2025 09:51
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)
3 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant