fix(warnings): ensure compilation without warnings with gcc 16 - #10583
Merged
Conversation
mgallien
requested review from
camilasan,
claucambra,
i2h3 and
nilsding
as code owners
August 12, 2026 12:50
mgallien
force-pushed
the
bugfix/fixWarningsWithGcc16
branch
2 times, most recently
from
August 31, 2026 15:15
e5c22e8 to
5422844
Compare
claucambra
approved these changes
Sep 1, 2026
mgallien
force-pushed
the
bugfix/fixWarningsWithGcc16
branch
from
September 1, 2026 09:10
5422844 to
c924d1e
Compare
mgallien
enabled auto-merge
September 1, 2026 09:11
mgallien
force-pushed
the
bugfix/fixWarningsWithGcc16
branch
from
September 1, 2026 09:31
c924d1e to
019fa47
Compare
Collaborator
Author
|
/backport to stable-34.0 please |
mgallien
disabled auto-merge
September 1, 2026 09:43
mgallien
enabled auto-merge
September 1, 2026 12:44
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10583.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
the new gcc 16 will trigger new warnings related to https://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Dialect-Options.html#index-Wsfinae-incomplete makes sure to fix them cleaned come include to ensure logical order of inclusions (from most specific to most generic ones) also makes incremental compilation faster by spliting MOC generated code into files related to each headers instead of a big one see https://forum.qt.io/topic/164690/gcc-16-warnings-about-incomplete-types-in-an-sfinae-context/2?_=1786535933996 also https://www.kdab.com/save-re-compile-time-include-moc-files-in-source-files-video/ Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/fixWarningsWithGcc16
branch
from
September 1, 2026 20:41
b7bb725 to
9459293
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the new gcc 16 will trigger new warnings related to https://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Dialect-Options.html#index-Wsfinae-incomplete
makes sure to fix them
cleaned come include to ensure logical order of inclusions (from most specific to most generic ones)
also makes incremental compilation faster by spliting MOC generated code into files related to each headers instead of a big one see https://forum.qt.io/topic/164690/gcc-16-warnings-about-incomplete-types-in-an-sfinae-context/2?_=1786535933996 also https://www.kdab.com/save-re-compile-time-include-moc-files-in-source-files-video/
Resolves
#
Summary
TODO
Checklist
AI (if applicable)