fix(warnings): ensure compilation without warnings with gcc 16

the new gcc 16 will trigger new warnings related to
https://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Dialect-Options.html#index-Wsfinae-incomplete

makes sure to fix them

cleaned come include to ensure logical order of inclusions (from most
specific to most generic ones)

also makes incremental compilation faster by spliting MOC generated code
into files related to each headers instead of a big one
see https://forum.qt.io/topic/164690/gcc-16-warnings-about-incomplete-types-in-an-sfinae-context/2?_=1786535933996
also https://www.kdab.com/save-re-compile-time-include-moc-files-in-source-files-video/

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Author: mgallien

src/common/syncjournaldb.cpp

@@ -4,6 +4,16 @@
  * SPDX-License-Identifier: LGPL-2.1-or-later
  */
 
+
+#include "syncjournaldb.h"
+
+#include "version.h"
+#include "filesystembase.h"
+#include "common/asserts.h"
+#include "common/checksums.h"
+#include "common/preparedsqlquerymanager.h"
+#include "common/c_jhash.h"
+
 #include <QCryptographicHash>
 #include <QFile>
 #include <QJsonArray>
@@ -13,17 +23,10 @@
 #include <QElapsedTimer>
 #include <QUrl>
 #include <QDir>
-#include <sqlite3.h>
-#include <cstring>
 
-#include "common/syncjournaldb.h"
-#include "version.h"
-#include "filesystembase.h"
-#include "common/asserts.h"
-#include "common/checksums.h"
-#include "common/preparedsqlquerymanager.h"
+#include <sqlite3.h>
 
-#include "common/c_jhash.h"
+#include <cstring>
 
 // SQL expression to check whether path.startswith(prefix + '/')
 // Note: '/' + 1 == '0'
@@ -3314,3 +3317,5 @@ QDebug& operator<<(QDebug &stream, const SyncJournalFileRecord::EncryptionStatus
 }
 
 } // namespace OCC
+
+#include "moc_syncjournaldb.cpp"

src/gui/socketapi/CMakeLists.txt

@@ -4,6 +4,7 @@
 target_sources(nextcloudCore PRIVATE
     ${CMAKE_CURRENT_SOURCE_DIR}/socketapi.h
     ${CMAKE_CURRENT_SOURCE_DIR}/socketapi.cpp
+    ${CMAKE_CURRENT_SOURCE_DIR}/socketapi_p.h
 )
 
 if( APPLE )

src/gui/socketapi/socketapi.cpp

@@ -1764,3 +1764,4 @@ void SocketApiJob::reject(const QString &response)
 } // namespace OCC
 
 #include "socketapi.moc"
+#include "moc_socketapi_p.cpp"

src/gui/socketapi/socketapi_p.h

@@ -7,16 +7,16 @@
 #ifndef SOCKETAPI_P_H
 #define SOCKETAPI_P_H
 
-#include <functional>
 #include <QBitArray>
 #include <QIODevice>
 #include <QPointer>
-
 #include <QJsonDocument>
 #include <QJsonObject>
+#include <QTimer>
+#include <QLoggingCategory>
 
+#include <functional>
 #include <memory>
-#include <QTimer>
 
 namespace OCC {
 

src/libsync/basepropagateremotedeleteencrypted.cpp

@@ -197,3 +197,5 @@ const QByteArray BasePropagateRemoteDeleteEncrypted::folderToken() const
 }
 
 } // namespace OCC
+
+#include "moc_basepropagateremotedeleteencrypted.cpp"

src/libsync/bulkpropagatordownloadjob.cpp

@@ -165,3 +165,5 @@ void BulkPropagatorDownloadJob::abortWithError(SyncFileItemPtr item, SyncFileIte
 }
 
 }
+
+#include "moc_bulkpropagatordownloadjob.cpp"

src/libsync/bulkpropagatorjob.cpp

@@ -819,3 +819,5 @@ void BulkPropagatorJob::handleJobDoneErrors(SyncFileItemPtr item,
 }
 
 }
+
+#include "moc_bulkpropagatorjob.cpp"

src/libsync/creds/abstractcredentials.cpp

@@ -4,12 +4,13 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
+#include "abstractcredentials.h"
+
 #include <QLoggingCategory>
 #include <QString>
 #include <QCoreApplication>
 
 #include "common/asserts.h"
-#include "creds/abstractcredentials.h"
 
 namespace OCC {
 
@@ -59,3 +60,5 @@ QString AbstractCredentials::keychainKey(const QString &url, const QString &user
     return key;
 }
 } // namespace OCC
+
+#include "moc_abstractcredentials.cpp"

src/libsync/creds/dummycredentials.cpp

@@ -58,3 +58,5 @@ void DummyCredentials::persist()
 }
 
 } // namespace OCC
+
+#include "moc_dummycredentials.cpp"

src/libsync/creds/httpcredentials.cpp

@@ -555,3 +555,5 @@ bool HttpCredentials::unpackClientCertBundle()
 }
 
 } // namespace OCC
+
+#include "moc_httpcredentials.cpp"