Skip to content

fix: don't crash MPC node on startup for failed attestation submission #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DSharifi merged 3 commits into from
Jan 16, 2026
Merged

fix: don't crash MPC node on startup for failed attestation submission #1772

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b328fa7
chore: remove redundant attestation submission
DSharifi Jan 15, 2026
9727de9
fix clippy lints
DSharifi Jan 16, 2026
69cd6db
Merge branch 'main' into 1763-bug-mpc-node-crashes-if-attestation-sub…
DSharifi Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions crates/node/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ use crate::{
use anyhow::{anyhow, Context};
use clap::{Args, Parser, Subcommand, ValueEnum};
use hex::FromHex;
use mpc_attestation::{attestation::Attestation, report_data::ReportDataV1};
use mpc_attestation::report_data::ReportDataV1;
use mpc_contract::state::ProtocolContractState;
use near_account_id::AccountId;
use near_indexer_primitives::types::Finality;
Expand All @@ -45,9 +45,7 @@ use crate::trait_extensions::convert_to_contract_dto::IntoContractInterfaceType;
use {
crate::tee::{
monitor_allowed_image_hashes,
remote_attestation::{
monitor_attestation_removal, periodic_attestation_submission, submit_remote_attestation,
},
remote_attestation::{monitor_attestation_removal, periodic_attestation_submission},
AllowedImageHashesFile,
},
mpc_contract::tee::proposal::MpcDockerImageHash,
Expand Down Expand Up @@ -295,7 +293,7 @@ impl StartCmd {
root_task_handle.clone(),
debug_request_sender.clone(),
config.web_ui,
static_web_data(&secrets, Some(attestation.clone())),
static_web_data(&secrets, Some(attestation)),
protocol_state_receiver,
migration_state_receiver,
))
Expand Down Expand Up @@ -351,7 +349,6 @@ impl StartCmd {
config.clone(),
secrets.clone(),
indexer_api,
attestation,
debug_request_sender,
root_task_handle,
tee_authority,
Expand Down Expand Up @@ -390,7 +387,6 @@ impl StartCmd {
config: ConfigFile,
secrets: SecretsConfig,
indexer_api: IndexerAPI<impl TransactionSender + 'static>,
attestation: Attestation,
debug_request_sender: broadcast::Sender<DebugRequest>,
// Cloning a OnceLock returns a new cell, which is why we have to wrap it in an arc.
// Otherwise we would not write to the same cell/lock.
Expand Down Expand Up @@ -434,13 +430,6 @@ impl StartCmd {
},
};

submit_remote_attestation(
indexer_api.txn_sender.clone(),
attestation,
tls_public_key.clone(),
)
.await?;

// Spawn periodic attestation submission task
let tee_authority_clone = tee_authority.clone();
let tx_sender_clone = indexer_api.txn_sender.clone();
Expand Down