Repository navigation
Conversation
netrome
approved these changes
Jan 16, 2026
DSharifi
enabled auto-merge
January 16, 2026 13:05
…mission-happens-before-the-node-keys-are-added-to-the-near-account
DSharifi
disabled auto-merge
January 16, 2026 14:09
DSharifi
enabled auto-merge
January 16, 2026 14:09
DSharifi
disabled auto-merge
January 16, 2026 14:37
DSharifi
deleted the
1763-bug-mpc-node-crashes-if-attestation-submission-happens-before-the-node-keys-are-added-to-the-near-account
branch
January 16, 2026 15:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1763
It's fine that we remove this manual attestation submission, since we spawn the periodic attestation submission just below.
Since we currently don't detach the submission in a separate task, the node will wait with starting the coordinator until the submission succeeds. If it fails, the node will crash itself which is not desirable.