Skip to content

refactor: clarify that tee_state contains attestations for not just active participants - #1695

Merged
gilcu3 merged 4 commits into
mainfrom
dsharifi/tee-state-validates-on-insertions
Dec 18, 2025
Merged

gilcu3 merged 4 commits into
mainfrom
dsharifi/tee-state-validates-on-insertions

Conversation

@DSharifi

Copy link
Copy Markdown
Contributor

closes #1693

@DSharifi DSharifi changed the title test: use attested participant that is also an active participant in with_attested_context helper refactor: clarify that tee_state contains attestations for not just active participants Dec 18, 2025
@DSharifi
DSharifi enabled auto-merge December 18, 2025 10:31

@gilcu3 gilcu3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread crates/contract/src/lib.rs
pub(crate) allowed_launcher_compose_hashes: Vec<LauncherDockerComposeHash>,
pub(crate) votes: CodeHashesVotes,
pub participants_attestations: IterableMap<near_sdk::PublicKey, (NodeId, Attestation)>,
/// Mapping of TLS public key of a participant to its NodeId and Attestation.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Mapping of TLS public key of a participant to its NodeId and Attestation.
/// Mapping of TLS public key of a participant to its [`NodeId`] and [`Attestation`].

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix in #1663

@DSharifi
DSharifi added this pull request to the merge queue Dec 18, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 18, 2025
@gilcu3
gilcu3 added this pull request to the merge queue Dec 18, 2025
Merged via the queue into main with commit 6977772 Dec 18, 2025
15 checks passed
@gilcu3
gilcu3 deleted the dsharifi/tee-state-validates-on-insertions branch December 18, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unit tests in contract expect with_attested_context to use active participant

3 participants