[DSharifi]

closes #1629

[barakeinav1]

overall look good,
I requested some changes (mainly nits, typo name etc..) ,
I also think you should add another test: (I didn't see something like it)

#[test]
fn re_verify_fails_after_allowed_hash_is_cleaned_up() {
// 1. Add allowed MPC hash H1 at time T0
// 2. Add participant attested with H1
// 3. Add new MPC hash H2 (upgrade)
// 4. Advance time > tee_upgrade_deadline_duration
// 5. cleanup_expired_hashes removes H1
// 6. re_verify_tee_participant fails
}

[barakeinav1]

approving with some comments to be address

[DSharifi]

overall look good, I requested some changes (mainly nits, typo name etc..) , I also think you should add another test: (I didn't see something like it)

#[test] fn re_verify_fails_after_allowed_hash_is_cleaned_up() { // 1. Add allowed MPC hash H1 at time T0 // 2. Add participant attested with H1 // 3. Add new MPC hash H2 (upgrade) // 4. Advance time > tee_upgrade_deadline_duration // 5. cleanup_expired_hashes removes H1 // 6. re_verify_tee_participant fails }

We already have integration tests in place.

[netrome]

A few blockers. We should understand better what's costing so much gas. Beyond this, we need to figure out how to introduce this change in a compatible way.

[DSharifi]

Carved out flaky test fix into #1695

[barakeinav1]

I open a bug for the issue I found:
Bug: MPC node crashes if attestation submission happens before the node keys are added to the near account#1763

[barakeinav1]

We already have integration tests in place.
can you point me to that test?
I'm just concerned that we are adding a new behaviour that is not covered before (but hopefully I'm wrong)

[barakeinav1]

overall look good.
2 blocking issue:

1. I added some small typo fixes,
2. Can you confirm that we have test coverage about expiration flows.

testing:
3 nodes setup is working, and gas cost is down !!!.

Also I opened a Bug: MPC node crashes if attestation submission happens before the node keys are added to the near account#1763.
so it can be handle separately if you prefer.

[DSharifi]

1. I added some small typo fixes,

Thanks for spotting, fixed now.

2. Can you confirm that we have test coverage about expiration flows.

Here:

• test_verify_tee_triggers_resharing_and_kickout_on_expired_attestation
• all of the unit tests in `tee_state.rs also cover this.

[barakeinav1]

thanks