Skip to content

Introduce new Ping/Pong message types #1781

Closed as not planned
Closed as not planned

Description

@netrome

Background

As a prerequisite for the echo connection check in #1687, we need to introduce the new Ping/Pong message types and respond to Ping messages with Pong messages.

Once this is released, we can follow-up with a change that starts sending the new Ping messages and expects Pong responses.

User Story

As a developer I want to introduce the Ping/Pong check without requiring a synchronous node upgrade.

Acceptance Criteria

Nodes recognize the new Ping/Pong message format and respond to Ping messages with Pong messages.

Resources & Additional Notes

No response

Activity

  1. added a commit that references this issue on Jan 16, 2026
    9dfcdb4
  2. pbeza commented on Jan 16, 2026

    @pbeza
    Contributor

    Closing this as discussed here.

    Instead, we’ll simply avoid sending pings to nodes that don’t support the new protocol version, which we can determine during the handshake.

  3. pbeza commented on Jan 16, 2026

    @pbeza
    Contributor

    @netrome Nit: maybe we could add a Won’t do label, so this issue can be marked as Won’t do rather than Done. I don’t think I have permission to add it myself.

  4. gilcu3 commented on Jan 16, 2026

    @gilcu3
    Contributor

    @pbeza I just closed it as not planned, which is equiv to won´t fix etc, seemed a better fit I think we have used it before for this purpose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions