Run CI on workflow and all script changes - #322
Merged
Conversation
The path filter enumerated four scripts, so a PR touching only scripts/install.sh or scripts/leak-check.sh skipped every job - including the new installer_scripts job, whose entire purpose is checking those two files. It also omitted .github/workflows, so a workflow edit skipped the job it edited. Replace the enumeration with scripts/** and add the workflows path. An explicit list drifts as jobs are added, which is how the installers ended up with a gate that would not have run on a change to them.
Contributor
|
| Filename | Overview |
|---|---|
| .github/workflows/build.yml | The recursive path patterns are supported by the pinned filter action and correctly broaden when the existing Rust-related jobs run. |
Reviews (2): Last reviewed commit: "Merge branch 'main' into ci/path-filters" | Re-trigger Greptile
Valgrind Memory Checks - PASSEDpie showData
title Leg A: compiled programs under Valgrind (113 total)
"Clean" : 113
"Leaking" : 0
Full valgrind output (last 300 lines)Benchmarks (report-only) - report-onlyInformational only - shared runners are too noisy to gate on; full data is in the run artifacts. xychart-beta
title "Compile phases (median)"
x-axis ["lex", "parse", "semantics", "codegen"]
y-axis "microseconds"
bar [14.01, 30.52, 97.16, 459.7]
xychart-beta
title "Pipeline + execution (median)"
x-axis ["pipeline", "execution"]
y-axis "milliseconds"
bar [0.6702, 61.53]
Full benchmark output (last 300 lines)Commit |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-applies a fix that never reached main: I pushed it to #317's branch after that PR had already merged, so it sat on a closed branch.
The gap
The
rustpath filter enumerates four scripts and omits.github/workflowsentirely, so:scripts/install.shorscripts/leak-check.shskips every Rust job - includinginstaller_scripts, whose entire purpose is checking those two files.This is not hypothetical. On #321, which fixes
scripts/install.shand.github/workflows/release.yml, every gating job reported SKIPPED -Installer Scriptsincluded. The claim in that PR that "the existinginstaller_scriptsjob guards this class from here on" is only true once this lands.The fix
scripts/**instead of an enumeration that drifts as jobs are added, plus.github/workflows/**.Same shape as the bug this whole line of work started from: a check that does not run where it matters. The v0.6.0 install shipped broken because no job exercised the packaged layout; these filters meant the jobs guarding that could themselves be skipped by exactly the changes most likely to break them.
Companion: muxlang/mux-runtime has the identical gap, fixed the same way.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.