Run CI on workflow changes - #29
Merged
Merged
Conversation
The runtime_src filter listed source and manifests but not .github/workflows, so a PR that only edits a workflow skipped every job - including the job it edits. This PR is exactly that case: it rewrites the Downstream Compiler Smoke Test and that job was skipped, so the rewrite went unexercised. A check that does not run where it matters is the same shape as the bug this branch documents, so wire workflow edits into the filter.
Contributor
|
| Filename | Overview |
|---|---|
| .github/workflows/ci.yml | Extends the valid runtime_src filter with .github/workflows/**, correctly causing workflow-only pull requests to run all jobs gated by that filter. |
Reviews (1): Last reviewed commit: "Run runtime CI on workflow changes" | Re-trigger Greptile
|
Valgrind Memory Checks - PASSEDpie showData
title Test binaries under Valgrind (28 total)
"Clean" : 28
"Leaking" : 0
Full valgrind output (last 300 lines)Benchmarks (report-only) - report-onlyInformational only - shared runners are too noisy to gate on; full data is in the run artifacts. xychart-beta
title "Hot paths under 1 us (median)"
x-axis ["refcount", "primitive", "map", "string", "wrappers"]
y-axis "nanoseconds"
bar [4.597, 3.579, 78.42, 48.25, 33.98]
xychart-beta
title "Hot paths 1 us and up (median)"
x-axis ["list", "set", "json"]
y-axis "microseconds"
bar [7.878, 19.5, 3.681]
Full benchmark output (last 300 lines)Commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-applies a fix that never reached main: I pushed it to #28's branch after that PR had already merged, so it sat on a closed branch.
The gap
The
runtime_srcfilter coverssrc/**,examples/**,benches/**and the manifests, but not.github/workflows/**. So a PR that only edits a workflow skips every job in this repo - including the job it is editing.#28 was exactly that case. It rewrote the
Downstream Compiler Smoke Testto force this checkout's runtime viaMUX_RUNTIME_LIB(the compiler no longer readsMUX_RUNTIME_SRC), and that job was skipped, so the rewrite merged unexercised.That job matters more than most: it is what catches FFI breaks at their origin, and the argument for not automating the compiler's runtime pin rests on it working.
The fix
Add
.github/workflows/**to the filter, so CI edits are exercised by the CI they edit.Companion: muxlang/mux-compiler#322 fixes the identical gap there.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.