Skip to content

[internal] Add CI check that the PR has label#32886

Merged
mnajdova merged 1 commit into
mui:masterfrom
mnajdova:ci/ensure-pr-has-label
May 25, 2022
Merged

[internal] Add CI check that the PR has label#32886
mnajdova merged 1 commit into
mui:masterfrom
mnajdova:ci/ensure-pr-has-label

Conversation

@mnajdova

@mnajdova mnajdova commented May 24, 2022

Copy link
Copy Markdown
Member

Tested in dimovi91#10, but apparently can also be tested on the PR itself :))

For the check, I've forked https://github.com/mheap/github-action-required-labels and added option for checking just minimum num of labels without needing to specify list of labels that should be applied.

@mui-bot

mui-bot commented May 24, 2022

Copy link
Copy Markdown

No bundle size changes

Generated by 🚫 dangerJS against 12c46db

@mnajdova
mnajdova marked this pull request as ready for review May 24, 2022 08:50
@mnajdova
mnajdova requested a review from a team May 24, 2022 10:07

@michaldudak michaldudak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Seems to be working fine :)

@mnajdova mnajdova added the internal Behind-the-scenes enhancement. Formerly called “core”. label May 25, 2022
@mnajdova
mnajdova merged commit 5661253 into mui:master May 25, 2022
@mnajdova

Copy link
Copy Markdown
Member Author

@DanailH is this something you want in the X too? It is blocking the PR from being merged if no label is added.

@DanailH

DanailH commented May 25, 2022

Copy link
Copy Markdown
Member

@DanailH is this something you want in the X too? It is blocking the PR from being merged if no label is added.

Yes, it looks like a useful limitation. I will duplicate the logic, open a PR and add you as a reviewer ;)

@oliviertassinari

oliviertassinari commented Aug 7, 2022

Copy link
Copy Markdown
Member

@mnajdova Regarding the build duration. In https://github.com/mui/material-ui/runs/7714987097?check_suite_focus=true, it has spent 41s to build the action. By that time, I have moved to a different tab. I didn't notice in #33843 that I forgot the label.

It would be better if it was running faster. I have found mheap/github-action-required-labels#2 (comment) and in practice, it's x10 faster for him: https://github.com/Kong/docs.konghq.com/runs/7701337497?check_suite_focus=true, 4s.

As far as I have looked at it, the problem is with the release. Compare the content of https://github.com/mnajdova/github-action-required-labels/releases/tag/v2.0 with the content of https://github.com/mheap/github-action-required-labels/releases/tag/v2.1.0. In our case, we rebuild the action for each run. In his case, he has the output of the action build 😁

@mnajdova

mnajdova commented Aug 10, 2022

Copy link
Copy Markdown
Member Author

Nice catch Olivier, it was exactly as you said. I've published v2.1.0 for the action (I thought I would need to also update our yml but it seems to have picked up the updated version). I've tried in #33795, it finished in 2s :)

image

@oliviertassinari

Copy link
Copy Markdown
Member

@oliviertassinari oliviertassinari changed the title [core] Add CI check that the PR has label [internal] Add CI check that the PR has label Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants