Skip to content

[alert] Constrain message width and allow overflow#32747

Merged
mnajdova merged 3 commits into
mui:masterfrom
Janpot:alert-overflow
Jun 3, 2022
Merged

[alert] Constrain message width and allow overflow#32747
mnajdova merged 3 commits into
mui:masterfrom
Janpot:alert-overflow

Conversation

@Janpot

@Janpot Janpot commented May 12, 2022

Copy link
Copy Markdown
Member

Reproduction: https://codesandbox.io/s/actionalerts-material-demo-forked-7fi9zq?file=/demo.tsx

Got hit by this while displaying stack traces in an Alert.

@mui-bot

mui-bot commented May 12, 2022

Copy link
Copy Markdown

Details of bundle changes

Generated by 🚫 dangerJS against 6867a57

@Janpot

Janpot commented May 12, 2022

Copy link
Copy Markdown
Member Author

Looks like the build hits this issue: #30200, #30201

@mnajdova mnajdova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's add a regression test for it. It should live here - https://github.com/mui/material-ui/tree/master/test/regressions/fixtures/Alert

@Janpot

Janpot commented May 19, 2022

Copy link
Copy Markdown
Member Author

@mnajdova mnajdova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Janpot

@mnajdova
mnajdova merged commit 00e0dc7 into mui:master Jun 3, 2022
@Janpot
Janpot deleted the alert-overflow branch June 3, 2022 13:16
@oliviertassinari oliviertassinari added type: bug It doesn't behave as expected. scope: alert Changes related to the alert. labels Jun 3, 2022
@oliviertassinari

Copy link
Copy Markdown
Member

@mnajdova I'm not sure that #32886 is working. It didn't seem to broke the CI on this PR, nor in #33009.

@mnajdova

Copy link
Copy Markdown
Member

@mnajdova I'm not sure that #32886 is working. It didn't seem to broke the CI on this PR, nor in #33009.

Could be because the PRs were open before the check was added.

@Janpot

Janpot commented Jun 24, 2022

Copy link
Copy Markdown
Member Author

I've definitely seen CI break on my last two PRs because of missing labels

@oliviertassinari oliviertassinari changed the title [Alert] Constrain message width and allow overflow [alert] Constrain message width and allow overflow May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: alert Changes related to the alert. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants