Skip to content

fix: GoToDate crash on non-English locales (5.1.1) #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mscrivo wants to merge 3 commits into from
Closed

fix: GoToDate crash on non-English locales (5.1.1) #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59682f3
chore: update nLog schemas
mscrivo Jul 11, 2026
aceb32e
fix: use InvariantCulture for GoToDate navigation to fix non-English …
mscrivo Jul 11, 2026
a399f8c
chore: bump version to 5.1.1
mscrivo Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions OotD.Core/Forms/MainForm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1176,7 +1176,7 @@ private void ButtonPrevious_Click(object sender, EventArgs e)

var (type, offset) = GetNextPreviousOffsetBasedOnCalendarViewMode(mode);
var targetDate = GetCalendarNavigationTargetDate(OutlookViewControl.SelectedDate, type, offset * -1);
OutlookViewControl.GoToDate(targetDate.ToString(CultureInfo.CurrentCulture));
OutlookViewControl.GoToDate(targetDate.ToString(CultureInfo.InvariantCulture));
}

private void ButtonNext_Click(object sender, EventArgs e)
Expand All @@ -1188,7 +1188,7 @@ private void ButtonNext_Click(object sender, EventArgs e)

var (type, offset) = GetNextPreviousOffsetBasedOnCalendarViewMode(mode);
var targetDate = GetCalendarNavigationTargetDate(OutlookViewControl.SelectedDate, type, offset);
OutlookViewControl.GoToDate(targetDate.ToString(CultureInfo.CurrentCulture));
OutlookViewControl.GoToDate(targetDate.ToString(CultureInfo.InvariantCulture));
}


Expand Down
6 changes: 6 additions & 0 deletions OotD.Core/NLog.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4591,6 +4591,7 @@
<xs:element name="maxRecursionLimit" type="xs:integer" minOccurs="0" maxOccurs="1" default="1" />
<xs:element name="renderEmptyObject" type="xs:boolean" minOccurs="0" maxOccurs="1" default="true" />
<xs:element name="suppressSpaces" type="xs:boolean" minOccurs="0" maxOccurs="1" default="false" />
<xs:element name="includeActivityIds" type="xs:boolean" minOccurs="0" maxOccurs="1" default="false" />
<xs:element name="includeScopes" type="xs:boolean" minOccurs="0" maxOccurs="1" default="false" />
<xs:element name="state" minOccurs="0" maxOccurs="unbounded" type="NLog.Layouts.JsonAttribute" />
<xs:element name="timestampFormat" type="xs:string" minOccurs="0" maxOccurs="1" default="o" />
Expand Down Expand Up @@ -4645,6 +4646,11 @@
<xs:documentation>Option to suppress the extra spaces in the output json.</xs:documentation>
</xs:annotation>
</xs:attribute>
<xs:attribute name="includeActivityIds" type="xs:boolean">
<xs:annotation>
<xs:documentation>Whether to include "TraceId" + "SpanId" + "ParentId" from P:System.Diagnostics.Activity.Current</xs:documentation>
</xs:annotation>
</xs:attribute>
<xs:attribute name="includeScopes" type="xs:boolean">
<xs:annotation>
<xs:documentation>Whether to include "scopes"-section</xs:documentation>
Expand Down
6 changes: 6 additions & 0 deletions OotD.Launcher/NLog.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4591,6 +4591,7 @@
<xs:element name="maxRecursionLimit" type="xs:integer" minOccurs="0" maxOccurs="1" default="1" />
<xs:element name="renderEmptyObject" type="xs:boolean" minOccurs="0" maxOccurs="1" default="true" />
<xs:element name="suppressSpaces" type="xs:boolean" minOccurs="0" maxOccurs="1" default="false" />
<xs:element name="includeActivityIds" type="xs:boolean" minOccurs="0" maxOccurs="1" default="false" />
<xs:element name="includeScopes" type="xs:boolean" minOccurs="0" maxOccurs="1" default="false" />
<xs:element name="state" minOccurs="0" maxOccurs="unbounded" type="NLog.Layouts.JsonAttribute" />
<xs:element name="timestampFormat" type="xs:string" minOccurs="0" maxOccurs="1" default="o" />
Expand Down Expand Up @@ -4645,6 +4646,11 @@
<xs:documentation>Option to suppress the extra spaces in the output json.</xs:documentation>
</xs:annotation>
</xs:attribute>
<xs:attribute name="includeActivityIds" type="xs:boolean">
<xs:annotation>
<xs:documentation>Whether to include "TraceId" + "SpanId" + "ParentId" from P:System.Diagnostics.Activity.Current</xs:documentation>
</xs:annotation>
</xs:attribute>
<xs:attribute name="includeScopes" type="xs:boolean">
<xs:annotation>
<xs:documentation>Whether to include "scopes"-section</xs:documentation>
Expand Down
2 changes: 1 addition & 1 deletion version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
5.1.0
5.1.1
Loading