fix: GoToDate crash on non-English locales (5.1.1)#332
Closed
mscrivo wants to merge 3 commits into
Closed
Conversation
…locale crash The Next/Previous calendar navigation buttons formatted the target date with CurrentCulture before passing it to the Outlook View Control's GoToDate. On non-English locales (e.g. de-DE producing 10.07.2026) the control could not parse the string and threw DISP_E_TYPEMISMATCH (0x80020005). Format with InvariantCulture to match the already-correct path in SetCurrentViewControlAsActiveIfNecessary.
Owner
Author
|
Merging directly to main instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A German user reported a crash (
DISP_E_TYPEMISMATCH, 0x80020005) when clicking the calendar Next/Previous navigation arrows.The Next/Previous handlers formatted the target date with
CultureInfo.CurrentCulturebefore passing it to the Outlook View Control'sGoToDate. On non-English locales (e.g. de-DE producing10.07.2026) the control cannot parse the string and throws a type-mismatch COM exception. It works on en-US because that producesMM/DD/YYYY.Fix
Format with
CultureInfo.InvariantCulturein both handlers, matching the already-correct call inSetCurrentViewControlAsActiveIfNecessary.OotD.Core/Forms/MainForm.cs— ButtonPrevious_Click, ButtonNext_ClickAlso bumps
version.txtto 5.1.1 for the release.