fix(rollup): build umd without react-is - #103
Open
jmfrancois wants to merge 1 commit into
Open
Conversation
2 similar comments
Contributor
|
You can add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
can t use hoist-non-react-statics as UMD in a browser: process.env is undefined
https://unpkg.com/browse/hoist-non-react-statics@3.3.2/dist/hoist-non-react-statics.js line 58 we see it
why:
Current UMD build contains react-is but not ready to be embeded, with process.env in it.
Proposed Solution
update rollup config to rely on react-is globally
UMD build is available for it:
https://unpkg.com/browse/react-is@16.8.6/umd/
This decreases the size of the final build and works well everywhere.