Skip to content

fix: build umd react-is process.env using replace plugin - #104

Open
jmfrancois wants to merge 1 commit into
mridgway:mainfrom
jmfrancois:jmfrancois/fix/umd-replace
Open

fix: build umd react-is process.env using replace plugin#104
jmfrancois wants to merge 1 commit into
mridgway:mainfrom
jmfrancois:jmfrancois/fix/umd-replace

Conversation

@jmfrancois

Copy link
Copy Markdown

Following #103 I propose here to follow the proposal of @TrySound
so you can choose:

replace plugin
2.7K hoist-non-react-statics.cjs.js
 15K hoist-non-react-statics.js
3.4K hoist-non-react-statics.min.js

without react-is from #103
2.7K  hoist-non-react-statics.cjs.js
3.3K hoist-non-react-statics.js
1.2K hoist-non-react-statics.min.js

@jmfrancois jmfrancois changed the title fix: build umd react-is process.env fix: build umd react-is process.env using replace plugin Nov 24, 2020
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 88.05% when pulling d96328f on jmfrancois:jmfrancois/fix/umd-replace into f3de655 on mridgway:master.

@alippai

alippai commented Jul 1, 2021

Copy link
Copy Markdown

While it's useful for development, I don't think a library should leak proptypes and react-is at all, it should be removed upon publishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants