Skip to content

Bug 1941337: Sign the Delta column and group thousands in metric values #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sumairq wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Bug 1941337: Sign the Delta column and group thousands in metric values #1071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84b14be
Add signPrefix and formatNumberFixedTwo helpers
sumairq Jul 26, 2026
60da8bb
Show explicit +/- sign on Delta percentage columns
sumairq Jul 26, 2026
e3c89cb
Group thousands in Mann-Whitney metric values
sumairq Jul 26, 2026
8a104ec
Make the comment for formatStat more accurate
sumairq Jul 26, 2026
8768dcf
Fix code format errors
sumairq Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
332 changes: 166 additions & 166 deletions src/__tests__/CompareResults/ResultsTable.test.tsx
View file
Open in desktop

Large diffs are not rendered by default.

148 changes: 74 additions & 74 deletions src/__tests__/CompareResults/SubtestsResultsView.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,10 +260,10 @@ describe('SubtestsResultsView Component Tests', () => {
// Initial view (alphabetical ordered, even if "sort by subtests" isn't specified
expect(summarizeVisibleRows()).toEqual([
'browser.html: -1.43 %, Low',
'dhtml.html: 1.14 %, Low',
'dhtml.html: +1.14 %, Low',
'improvement.html: -1.44 %, Low',
'regression.html: 1.04 %, High',
'tablemutation.html: 0.98 %, Low',
'regression.html: +1.04 %, High',
'tablemutation.html: +0.98 %, Low',
]);

// Sort by Delta
Expand All @@ -276,9 +276,9 @@ describe('SubtestsResultsView Component Tests', () => {
expect(summarizeVisibleRows()).toEqual([
'improvement.html: -1.44 %, Low',
'browser.html: -1.43 %, Low',
'dhtml.html: 1.14 %, Low',
'regression.html: 1.04 %, High',
'tablemutation.html: 0.98 %, Low',
'dhtml.html: +1.14 %, Low',
'regression.html: +1.04 %, High',
'tablemutation.html: +0.98 %, Low',
]);
// It should have the "descending" SVG.
expect(deltaButton).toMatchSnapshot();
Expand All @@ -288,9 +288,9 @@ describe('SubtestsResultsView Component Tests', () => {
// Sort ascending
await user.click(deltaButton);
expect(summarizeVisibleRows()).toEqual([
'tablemutation.html: 0.98 %, Low',
'regression.html: 1.04 %, High',
'dhtml.html: 1.14 %, Low',
'tablemutation.html: +0.98 %, Low',
'regression.html: +1.04 %, High',
'dhtml.html: +1.14 %, Low',
'browser.html: -1.43 %, Low',
'improvement.html: -1.44 %, Low',
]);
Expand All @@ -305,11 +305,11 @@ describe('SubtestsResultsView Component Tests', () => {
});
await user.click(confidenceButton);
expect(summarizeVisibleRows()).toEqual([
'regression.html: 1.04 %, High',
'regression.html: +1.04 %, High',
'improvement.html: -1.44 %, Low',
'browser.html: -1.43 %, Low',
'dhtml.html: 1.14 %, Low',
'tablemutation.html: 0.98 %, Low',
'dhtml.html: +1.14 %, Low',
'tablemutation.html: +0.98 %, Low',
]);
// It should have the "no sort" SVG.
expect(deltaButton).toMatchSnapshot();
Expand All @@ -322,10 +322,10 @@ describe('SubtestsResultsView Component Tests', () => {
const subtestsButton = screen.getByRole('button', { name: /Subtests/ });
await user.click(subtestsButton);
expect(summarizeVisibleRows()).toEqual([
'tablemutation.html: 0.98 %, Low',
'regression.html: 1.04 %, High',
'tablemutation.html: +0.98 %, Low',
'regression.html: +1.04 %, High',
'improvement.html: -1.44 %, Low',
'dhtml.html: 1.14 %, Low',
'dhtml.html: +1.14 %, Low',
'browser.html: -1.43 %, Low',
]);
// It should have the "no sort" SVG.
Expand All @@ -345,9 +345,9 @@ describe('SubtestsResultsView Component Tests', () => {
await setupForSorting({ extraParameters: 'sort=delta|asc' });
await screen.findByText('dhtml.html');
expect(summarizeVisibleRows()).toEqual([
'tablemutation.html: 0.98 %, Low',
'regression.html: 1.04 %, High',
'dhtml.html: 1.14 %, Low',
'tablemutation.html: +0.98 %, Low',
'regression.html: +1.04 %, High',
'dhtml.html: +1.14 %, Low',
'browser.html: -1.43 %, Low',
'improvement.html: -1.44 %, Low',
]);
Expand All @@ -361,9 +361,9 @@ describe('SubtestsResultsView Component Tests', () => {
expect(summarizeVisibleRows()).toEqual([
'improvement.html: -1.44 %, Low',
'browser.html: -1.43 %, Low',
'dhtml.html: 1.14 %, Low',
'regression.html: 1.04 %, High',
'tablemutation.html: 0.98 %, Low',
'dhtml.html: +1.14 %, Low',
'regression.html: +1.04 %, High',
'tablemutation.html: +0.98 %, Low',
]);
// It should have the "descending" SVG.
expect(screen.getByRole('button', { name: /Delta/ })).toMatchSnapshot();
Expand All @@ -374,9 +374,9 @@ describe('SubtestsResultsView Component Tests', () => {
expect(summarizeVisibleRows()).toEqual([
'improvement.html: -1.44 %, Low',
'browser.html: -1.43 %, Low',
'dhtml.html: 1.14 %, Low',
'regression.html: 1.04 %, High',
'tablemutation.html: 0.98 %, Low',
'dhtml.html: +1.14 %, Low',
'regression.html: +1.04 %, High',
'tablemutation.html: +0.98 %, Low',
]);
// It should have the "descending" SVG.
expect(screen.getByRole('button', { name: /Delta/ })).toMatchSnapshot();
Expand Down Expand Up @@ -527,11 +527,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
await setupForSorting();
// Initial view (alphabetical ordered, even if "sort by subtests" isn't specified
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'browser.html: 0.963 %, -0.04, -, 15.00%',
'dhtml.html: 1.135 %, 0.02, , 60.00%',
'improvement.html: 0.963 %, -0.05, , 50.00%',
'regression.html: 1.135 %, 0.12, , 25.00%',
'tablemutation.html: 0.98 %, 0.01, -, 45.00%',
'browser.html: +0.963 %, -0.04, -, 15.00%',
'dhtml.html: +1.135 %, 0.02, , 60.00%',
'improvement.html: +0.963 %, -0.05, , 50.00%',
'regression.html: +1.135 %, 0.12, , 25.00%',
'tablemutation.html: +0.98 %, 0.01, -, 45.00%',
]);

// Sort by Delta
Expand All @@ -542,11 +542,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
// Sort descending
await user.click(deltaButton);
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'regression.html: 1.135 %, 0.12, , 25.00%',
'improvement.html: 0.963 %, -0.05, , 50.00%',
'browser.html: 0.963 %, -0.04, -, 15.00%',
'dhtml.html: 1.135 %, 0.02, , 60.00%',
'tablemutation.html: 0.98 %, 0.01, -, 45.00%',
'regression.html: +1.135 %, 0.12, , 25.00%',
'improvement.html: +0.963 %, -0.05, , 50.00%',
'browser.html: +0.963 %, -0.04, -, 15.00%',
'dhtml.html: +1.135 %, 0.02, , 60.00%',
'tablemutation.html: +0.98 %, 0.01, -, 45.00%',
]);

// It should have the "descending" SVG.
Expand All @@ -557,11 +557,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
// Sort ascending
await user.click(deltaButton);
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'tablemutation.html: 0.98 %, 0.01, -, 45.00%',
'dhtml.html: 1.135 %, 0.02, , 60.00%',
'browser.html: 0.963 %, -0.04, -, 15.00%',
'improvement.html: 0.963 %, -0.05, , 50.00%',
'regression.html: 1.135 %, 0.12, , 25.00%',
'tablemutation.html: +0.98 %, 0.01, -, 45.00%',
'dhtml.html: +1.135 %, 0.02, , 60.00%',
'browser.html: +0.963 %, -0.04, -, 15.00%',
'improvement.html: +0.963 %, -0.05, , 50.00%',
'regression.html: +1.135 %, 0.12, , 25.00%',
]);
// It should have the "ascending" SVG.
expect(deltaButton).toMatchSnapshot();
Expand All @@ -574,11 +574,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
});
await user.click(significanceButton);
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'browser.html: 0.963 %, -0.04, -, 15.00%',
'tablemutation.html: 0.98 %, 0.01, -, 45.00%',
'dhtml.html: 1.135 %, 0.02, , 60.00%',
'regression.html: 1.135 %, 0.12, , 25.00%',
'improvement.html: 0.963 %, -0.05, , 50.00%',
'browser.html: +0.963 %, -0.04, -, 15.00%',
'tablemutation.html: +0.98 %, 0.01, -, 45.00%',
'dhtml.html: +1.135 %, 0.02, , 60.00%',
'regression.html: +1.135 %, 0.12, , 25.00%',
'improvement.html: +0.963 %, -0.05, , 50.00%',
]);
// It should have the "no sort" SVG.
expect(deltaButton).toMatchSnapshot();
Expand All @@ -590,11 +590,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
// Sort by Significance ascending
await user.click(significanceButton);
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'improvement.html: 0.963 %, -0.05, , 50.00%',
'regression.html: 1.135 %, 0.12, , 25.00%',
'dhtml.html: 1.135 %, 0.02, , 60.00%',
'tablemutation.html: 0.98 %, 0.01, -, 45.00%',
'browser.html: 0.963 %, -0.04, -, 15.00%',
'improvement.html: +0.963 %, -0.05, , 50.00%',
'regression.html: +1.135 %, 0.12, , 25.00%',
'dhtml.html: +1.135 %, 0.02, , 60.00%',
'tablemutation.html: +0.98 %, 0.01, -, 45.00%',
'browser.html: +0.963 %, -0.04, -, 15.00%',
]);
expectParameterToHaveValue('sort', 'significance|asc');

Expand All @@ -604,11 +604,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
});
await user.click(effectButton);
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'browser.html: 0.963 %, -0.04, -, 15.00%',
'regression.html: 1.135 %, 0.12, , 25.00%',
'dhtml.html: 1.135 %, 0.02, , 60.00%',
'tablemutation.html: 0.98 %, 0.01, -, 45.00%',
'improvement.html: 0.963 %, -0.05, , 50.00%',
'browser.html: +0.963 %, -0.04, -, 15.00%',
'regression.html: +1.135 %, 0.12, , 25.00%',
'dhtml.html: +1.135 %, 0.02, , 60.00%',
'tablemutation.html: +0.98 %, 0.01, -, 45.00%',
'improvement.html: +0.963 %, -0.05, , 50.00%',
]);

// It should have the "descending" SVG.
Expand All @@ -619,11 +619,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
// Sort by Effect Size ascending
await user.click(effectButton);
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'improvement.html: 0.963 %, -0.05, , 50.00%',
'tablemutation.html: 0.98 %, 0.01, -, 45.00%',
'dhtml.html: 1.135 %, 0.02, , 60.00%',
'regression.html: 1.135 %, 0.12, , 25.00%',
'browser.html: 0.963 %, -0.04, -, 15.00%',
'improvement.html: +0.963 %, -0.05, , 50.00%',
'tablemutation.html: +0.98 %, 0.01, -, 45.00%',
'dhtml.html: +1.135 %, 0.02, , 60.00%',
'regression.html: +1.135 %, 0.12, , 25.00%',
'browser.html: +0.963 %, -0.04, -, 15.00%',
]);
expectParameterToHaveValue('sort', 'effects|asc');
});
Expand All @@ -632,11 +632,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
await setupForSorting({ extraParameters: 'sort=delta|asc' });
await screen.findByText('dhtml.html');
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'tablemutation.html: 0.98 %, 0.01, -, 45.00%',
'dhtml.html: 1.135 %, 0.02, , 60.00%',
'browser.html: 0.963 %, -0.04, -, 15.00%',
'improvement.html: 0.963 %, -0.05, , 50.00%',
'regression.html: 1.135 %, 0.12, , 25.00%',
'tablemutation.html: +0.98 %, 0.01, -, 45.00%',
'dhtml.html: +1.135 %, 0.02, , 60.00%',
'browser.html: +0.963 %, -0.04, -, 15.00%',
'improvement.html: +0.963 %, -0.05, , 50.00%',
'regression.html: +1.135 %, 0.12, , 25.00%',
]);
// It should have the "ascending" SVG.
expect(screen.getByRole('button', { name: /CD/ })).toMatchSnapshot();
Expand All @@ -646,11 +646,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
await setupForSorting({ extraParameters: 'sort=delta' });
await screen.findByText('dhtml.html');
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'regression.html: 1.135 %, 0.12, , 25.00%',
'improvement.html: 0.963 %, -0.05, , 50.00%',
'browser.html: 0.963 %, -0.04, -, 15.00%',
'dhtml.html: 1.135 %, 0.02, , 60.00%',
'tablemutation.html: 0.98 %, 0.01, -, 45.00%',
'regression.html: +1.135 %, 0.12, , 25.00%',
'improvement.html: +0.963 %, -0.05, , 50.00%',
'browser.html: +0.963 %, -0.04, -, 15.00%',
'dhtml.html: +1.135 %, 0.02, , 60.00%',
'tablemutation.html: +0.98 %, 0.01, -, 45.00%',
]);
// It should have the "descending" SVG.
expect(screen.getByRole('button', { name: /CD/ })).toMatchSnapshot();
Expand All @@ -659,11 +659,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
it('initializes the sort from the URL at load time for a descending sort', async () => {
await setupForSorting({ extraParameters: 'sort=delta|desc' });
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'regression.html: 1.135 %, 0.12, , 25.00%',
'improvement.html: 0.963 %, -0.05, , 50.00%',
'browser.html: 0.963 %, -0.04, -, 15.00%',
'dhtml.html: 1.135 %, 0.02, , 60.00%',
'tablemutation.html: 0.98 %, 0.01, -, 45.00%',
'regression.html: +1.135 %, 0.12, , 25.00%',
'improvement.html: +0.963 %, -0.05, , 50.00%',
'browser.html: +0.963 %, -0.04, -, 15.00%',
'dhtml.html: +1.135 %, 0.02, , 60.00%',
'tablemutation.html: +0.98 %, 0.01, -, 45.00%',
]);
// It should have the "descending" SVG.
expect(screen.getByRole('button', { name: /CD/ })).toMatchSnapshot();
Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/CompareResults/SubtestsRevisionRow.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe('SubtestsRevisionRow Component', () => {
await screen.findByText('dhtml.html');
expect(await screen.findByText('971.38 ms')).toBeInTheDocument();
expect(await screen.findByText('982.41 ms')).toBeInTheDocument();
expect(await screen.findByText('1.14 %')).toBeInTheDocument();
expect(await screen.findByText('+1.14 %')).toBeInTheDocument();
expect(await screen.findByText('Low')).toBeInTheDocument();
expect(document.body).toMatchSnapshot();
});
Expand Down
Loading