Bug 1941337: Sign the Delta column and group thousands in metric values - #1071
Open
sumairq wants to merge 5 commits into
Open
Bug 1941337: Sign the Delta column and group thousands in metric values#1071sumairq wants to merge 5 commits into
sumairq wants to merge 5 commits into
Conversation
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves numeric formatting in the comparison results, addressing the two asks in
Bug 1941337:
with a leading
+(e.g.+53.31 %instead of53.31 %), so direction isimmediately readable alongside the existing
-on negatives.grouping separator (e.g.
2,113.69), completing the work started in Format numbers in revision and subtests revision rows #828 whichcovered the Base/New columns.
Locale stays hardcoded to
en-US, per the decision recorded on the bug.Changes
Sign (
+) on directional percentages — via a smallsignPrefixhelper:"Difference of means" / "Difference of medians" lines.
(−1…1), p-values, and confidence.
Thousands grouping on measurement values — via
formatNumberFixedTwo(grouping.toFixed(2)appearance):RunValues: the overflow individual run values and the standard-deviation linenow group consistently with the first-100 values and Base/New columns from Format numbers in revision and subtests revision rows #828.
Notes / decisions
sign, not a separator.
exactly 2 decimals (mirroring
.toFixed(2));RunValuesreuses the existingformatNumber, so its values follow the same ≤3-decimal display as the rest ofthe column (real run values are ≤2 decimals, so this is not visible in practice;
full precision is still preserved by the "Copy results" button).
formatNumber/dateFormatterinsrc/utils/format.ts.🤖 Generated with Claude Code