Fix black triangle rendering issue on goblet.3ds and broom.3ds - #42
Fix black triangle rendering issue on goblet.3ds and broom.3ds#42moonwho101 wants to merge 1 commit into
Conversation
…dels Co-authored-by: moonwho101 <90150577+moonwho101@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Updated CalculateVertNormalAndTangent, Compute3DSModelNormals, ComputeMD2ModelNormals, ComputeObDataNormals, ObjectToD3DVertList, PlayerToD3DVertList, and PlayerToD3DIndexedVertList in src/ProcessModel.cpp to handle zero-length normals and tangents for degenerate faces/UVs gracefully by providing valid unit fallback vectors. This prevents NaN and zero-vector generation during DirectXMath transformations, fixing the black triangle rendering artifacts on models such as goblet.3ds and broom.3DS.
PR created automatically by Jules for task 14733320370972258639 started by @moonwho101