Skip to content

Update LoadObjectData to generate MikkTSpace tangents and simplify ObjectToD3DVertList - #40

Open
moonwho101 wants to merge 2 commits into
DS-mikktspace-allfrom
jules-199700106468598252-67b607a4
Open

Update LoadObjectData to generate MikkTSpace tangents and simplify ObjectToD3DVertList#40
moonwho101 wants to merge 2 commits into
DS-mikktspace-allfrom
jules-199700106468598252-67b607a4

Conversation

@moonwho101

Copy link
Copy Markdown
Owner

Added ComputeObDataNormals using MikkTSpace in ProcessModel.cpp and updated CLoadWorld::LoadObjectData in LoadWorld.cpp to generate and store MikkTSpace tangent spaces in obdata at load time. Refactored ObjectToD3DVertList to remove redundant intermediate arrays and transform vertex position, texture coordinates, normals, and tangents directly from obdata.


PR created automatically by Jules for task 199700106468598252 started by @moonwho101

Co-authored-by: moonwho101 <90150577+moonwho101@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: moonwho101 <90150577+moonwho101@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant