Update ObjectToD3DVertList to use MikkTSpace - #38
Conversation
Integrated MikkTSpace tangent space generation into ObjectToD3DVertList in src/ProcessModel.cpp, matching the implementation used in Compute3DSModelNormals and ComputeMD2ModelNormals. Defined ObjectMikkUserData and the required SMikkTSpaceInterface callbacks for D3DVERTEX2 array src_v, and invoke genTangSpaceDefault at the end of ObjectToD3DVertList. Co-authored-by: moonwho101 <90150577+moonwho101@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…ce correctly Integrated MikkTSpace tangent space generation into ObjectToD3DVertList in src/ProcessModel.cpp. Additionally, reviewed and fixed Compute3DSModelNormals and ThreeDSMikk_GetTexCoord by inverting the V texture coordinate (1.0 - V) to match PlayerToD3DIndexedVertList, removing coordinate swapping during initial face normal calculations, normalizing accumulated vertex normals, and adding orthogonal fallback tangents to fix black triangle rendering artifacts on 3DS models. Co-authored-by: moonwho101 <90150577+moonwho101@users.noreply.github.com>
1 participant
Updates ObjectToD3DVertList in src/ProcessModel.cpp to use MikkTSpace tangent generation matching Compute3DSModelNormals and ComputeMD2ModelNormals.
PR created automatically by Jules for task 12796579724784164357 started by @moonwho101