Add MikkTSpace support to ImportMD2 - #37
Conversation
Implemented Morten S. Mikkelsen's MikkTSpace tangent space generator in src/mikktspace.h and src/mikktspace.cpp, and added them to project files. Updated ImportMD2_GLCMD to split vertices at UV seams into distinct pmdata.w and pmdata.f entries, and updated ComputeMD2ModelNormals in ProcessModel.cpp to calculate per-vertex tangent space using genTangSpaceDefault. Co-authored-by: moonwho101 <90150577+moonwho101@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Implemented Morten S. Mikkelsen's MikkTSpace tangent space generator in src/mikktspace.h and src/mikktspace.cpp and added them to project files. Updated ImportMD2_GLCMD to split MD2 vertices at UV seams into distinct pmdata.w and pmdata.f entries. Integrated genTangSpaceDefault into both ComputeMD2ModelNormals and Compute3DSModelNormals in ProcessModel.cpp. Co-authored-by: moonwho101 <90150577+moonwho101@users.noreply.github.com>
1 participant
Added MikkTSpace support to MD2 model loading and processing. Added mikktspace.h and mikktspace.cpp to src/ and project files, updated ImportMD2_GLCMD to split vertices at UV seams, and integrated genTangSpaceDefault into ComputeMD2ModelNormals.
PR created automatically by Jules for task 9057300856946491174 started by @moonwho101