Fix inverted 3DS model normals for DXR raytracing shadows - #34
Conversation
In Compute3DSModelNormals, negate the computed face normal and tangent vectors assigned to each vertex. This accounts for the 3DS coordinate system and winding order when converted to DirectX space, ensuring 3DS models (such as coin.3ds) have outward-pointing normals for correct raytracing shadows and PBR lighting. Co-authored-by: moonwho101 <90150577+moonwho101@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixed inverted 3DS model normals in
Compute3DSModelNormalsinsrc/ProcessModel.cpp. The face normal and tangent vectors are now negated when assigned to vertices, accounting for 3DS winding order in DirectX space. This ensures models likecoin.3dsrender with outward-pointing surface normals and receive accurate PBR lighting and DXR raytraced shadows.PR created automatically by Jules for task 3278180875424336755 started by @moonwho101