Skip to content

chore: default draft tag message to version name MONGOSH-3554 #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dudaschar merged 1 commit into from
Aug 5, 2026
Merged

chore: default draft tag message to version name MONGOSH-3554 #2816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/build/src/local/trigger-release-draft.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ describe('local trigger-release-draft', function () {
expect(spawnSync).to.have.been.calledTwice;
expect(spawnSync.getCall(0)).calledWith(
'git',
['tag', 'v0.8.0-draft.8'],
['tag', '-m', 'v0.8.0-draft.8', 'v0.8.0-draft.8'],
sinon.match.any
);
expect(spawnSync.getCall(1)).calledWith(
Expand Down Expand Up @@ -99,7 +99,7 @@ describe('local trigger-release-draft', function () {
expect(spawnSync).to.have.been.calledTwice;
expect(spawnSync.getCall(0)).calledWith(
'git',
['tag', 'v0.9.0-draft.0'],
['tag', '-m', 'v0.9.0-draft.0', 'v0.9.0-draft.0'],
sinon.match.any
);
expect(spawnSync.getCall(1)).calledWith(
Expand Down Expand Up @@ -147,7 +147,7 @@ describe('local trigger-release-draft', function () {
expect(spawnSync).to.have.been.calledTwice;
expect(spawnSync.getCall(0)).calledWith(
'git',
['tag', 'v0.8.3-draft.0'],
['tag', '-m', 'v0.8.3-draft.0', 'v0.8.3-draft.0'],
sinon.match.any
);
expect(spawnSync.getCall(1)).calledWith(
Expand Down
2 changes: 1 addition & 1 deletion packages/build/src/local/trigger-release-draft.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export async function triggerReleaseDraft(
}

console.info('... creating and pushing tag ...');
spawnSync('git', ['tag', nextTagName], {
spawnSync('git', ['tag', '-m', nextTagName, nextTagName], {
cwd: repositoryRoot,
encoding: 'utf-8',
});
Comment on lines 87 to 91

@dudaschar dudaschar Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait to actually publish to see if it's a real concern before updating.

@dudaschar dudaschar Aug 5, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, this will take a while so I will merge and if we need we can open another PR.

Expand Down
Loading