chore: default draft tag message to version name MONGOSH-3554 - #2816
Merged
Conversation
lerouxb
approved these changes
Aug 4, 2026
nbbeeken
approved these changes
Aug 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the local release-draft helper to create git tags non-interactively by defaulting the tag message to the version/tag name, addressing hangs when git tag signing triggers an editor prompt.
Changes:
- Create draft tags using
git tag -m <tag> <tag>so a message is always provided. - Update unit tests to assert the new
git tagargument list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/build/src/local/trigger-release-draft.ts | Adds -m <tag> when creating the draft tag to avoid interactive editor prompts. |
| packages/build/src/local/trigger-release-draft.spec.ts | Updates assertions to match the new git tag invocation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
87
to
91
| console.info('... creating and pushing tag ...'); | ||
| spawnSync('git', ['tag', nextTagName], { | ||
| spawnSync('git', ['tag', '-m', nextTagName, nextTagName], { | ||
| cwd: repositoryRoot, | ||
| encoding: 'utf-8', | ||
| }); |
Collaborator
Author
There was a problem hiding this comment.
I'll wait to actually publish to see if it's a real concern before updating.
Collaborator
Author
There was a problem hiding this comment.
ok, this will take a while so I will merge and if we need we can open another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the tag creation is signed in, the process was hanging locally because git was waiting for a message confirmation.
This change defaults the message to be the tag name, if necessary.