Skip to content

fix(edit-pdf): cover style changes with undo history #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3ni8ma wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(edit-pdf): cover style changes with undo history #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/operations/edit-pdf/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,14 @@ export default function EditPdf() {

const updateAnno = (id, patch) => setAnnos((prev) => prev.map((a) => (a.id === id ? { ...a, ...patch } : a)))
// Apply a style change to the currently-selected annotation (if any).
const patchSelected = (patch) => selectedId && updateAnno(selectedId, patch)
// Goes through `commit` (not `updateAnno`) so style edits land in undo
// history. `updateAnno` stays raw on purpose: it also serves drag/resize
// `onChange`, which fires many updates per gesture.
const patchSelected = (patch) => {
if (!selectedId) return
const id = selectedId
commit((prev) => prev.map((a) => (a.id === id ? { ...a, ...patch } : a)))
}

// ── erase (delete added items under the cursor) ──
const distToSeg = (px, py, x1, y1, x2, y2) => {
Expand Down
Loading