fix(edit-pdf): cover style changes with undo history - #215
Open
3ni8ma wants to merge 1 commit into
Open
Conversation
Route patchSelected through commit so color/width/font/bold/italic edits land in the undo stack. updateAnno stays raw since it also serves drag/resize onChange. Fixes mithun-srinivas#21
|
@3ni8ma is attempting to deploy a commit to the Mithun Srinivas' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21.
Root cause: patchSelected delegated to updateAnno, which writes via raw setAnnos and bypasses the history-recording commit. All five style controls (color, width, font family, font size, bold/italic) therefore skipped the undo stack.
Change: patchSelected now applies its patch through commit. updateAnno is intentionally left raw since it also serves AnnotationBox drag/resize onChange, where per-move commits would flood the undo stack.
Tests: eslint clean (0 errors, warnings unchanged pre/post), unit suite 40/40 pass, updater semantics simulated (style change then undo restores prior style).