Add setupPretender test helper - #437
Merged
Merged
Conversation
alexlafroscia
commented
Apr 9, 2020
Contributor
Author
|
Something is "up" with Travis; test run was not reported to the PR but it did actually run https://travis-ci.org/github/mike-north/ember-api-actions/builds/673039505 |
Contributor
Author
|
Travis run is green, I'm going to merge this (and rebase #428 which should use the new helper) |
Contributor
Author
|
Actually, I can't merge 😅 @Turbo87 could you? |
Collaborator
|
I would be more comfortable if we had a working CI setup here first 😅 |
The TypeScript types in the version of Pretender that the current version of `ember-cli-pretender` provides don't match the actual API of pretender _or_ the way that we were using it. Upgrade `ember-cli-pretender` bumped Pretender itself to the next major version, which ships with more accurate types.
* Add `setupPretender` helper that provides Pretender to the test context (with correct types!) * Update tests so that there are no TypeScript errors in Pretender handlers
alexlafroscia
force-pushed
the
setup-pretender
branch
from
April 9, 2020 16:19
0d39b20 to
8df6a78
Compare
Contributor
Author
|
Rebased to trigger CI... and now Travis is reporting again??? 🤷♂️ |
Collaborator
|
|
Contributor
Author
|
@Turbo87 this looks ready-to-go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setupPretenderhelper (with type augmentation!)