Skip to content

fix: avoid shell interpretation in release tooling #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KevinTran3011 wants to merge 1 commit into from
Closed

fix: avoid shell interpretation in release tooling #502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions runtime/python/prompty/scripts/release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import argparse
import re
import shlex
import subprocess
import sys
from pathlib import Path
Expand Down Expand Up @@ -76,9 +77,10 @@ def bump_version(current: str, bump: str) -> str:
sys.exit(1)


def run(cmd: str) -> None:
print(f" $ {cmd}")
subprocess.run(cmd, cwd=REPO_ROOT, shell=True, check=True)
def run(cmd: list[str]) -> None:
"""Run a release command without invoking a shell."""
print(f" $ {shlex.join(cmd)}")
subprocess.run(cmd, cwd=REPO_ROOT, check=True)


def main() -> None:
Expand Down Expand Up @@ -116,12 +118,12 @@ def main() -> None:

# Git commit, tag, push
print("\n🔖 Creating commit and tag...\n")
run("git add runtime/python/prompty/prompty/_version.py")
run(f'git commit -m "chore(python): release v{new_version}"')
run(f'git tag -a {tag} -m "{tag}"')
run(["git", "add", "runtime/python/prompty/prompty/_version.py"])
run(["git", "commit", "-m", f"chore(python): release v{new_version}"])
run(["git", "tag", "-a", tag, "-m", tag])

print("\n🚀 Pushing to origin...\n")
run("git push origin main --follow-tags")
run(["git", "push", "origin", "main", "--follow-tags"])

print(f"\n✅ Done! Tag {tag} pushed.")
print(" CI will build, test, and publish to PyPI.\n")
Expand Down