Skip to content

fix: avoid shell interpretation in release tooling - #502

Closed
KevinTran3011 wants to merge 1 commit into
microsoft:mainfrom
KevinTran3011:security/codeql-research-findings
Closed

KevinTran3011 wants to merge 1 commit into
microsoft:mainfrom
KevinTran3011:security/codeql-research-findings

Conversation

@KevinTran3011

Copy link
Copy Markdown

No description provided.

@KevinTran3011

Copy link
Copy Markdown
Author

Research note: the release script was a custom-query false negative for CWE-78/CWE-94. It constructed git commands from the version/tag value and executed them with shell=True. The patch changes the runner to argv lists with shell=False and uses shlex.join only for display, so version text cannot become shell syntax.

@KevinTran3011

KevinTran3011 commented Aug 24, 2026 via email

Copy link
Copy Markdown
Author

@sethjuarez

Copy link
Copy Markdown
Member

Thanks for the shell-hardening fix. I recreated this from a first-party branch in #571 because this PR is blocked on CLA.

@sethjuarez

Copy link
Copy Markdown
Member

Closing in favor of #571, which recreates this shell-hardening fix from a first-party branch and has green checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants