fix: Normalize terminology in sample updates#1397
Open
IEvangelist wants to merge 2 commits into
Open
Conversation
![aspire-repo-bot[bot]](https://avatars.githubusercontent.com/in/3085065?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes terminology normalization (e.g., replacing “.NET Aspire” and “app host”) into a shared helper and applies it during data generation to keep samples.json and integration metadata consistent going forward, addressing the regression noted in #1393.
Changes:
- Introduces
normalizeAspireTerminology()and reuses it across generators. - Normalizes sample titles/descriptions/README text/AppHost code during
update-samplesgeneration and makes the script safe to import in tests by guarding themain()entrypoint. - Updates integration description normalization to use the shared helper and adds unit coverage (including asserting existing
samples.jsonhas no deprecated terms).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/frontend/tests/unit/update-samples.vitest.test.ts | Adds unit tests for sample terminology normalization and validates generated samples.json is clean. |
| src/frontend/src/utils/samples.ts | Updates documentation comment to reflect that readmeRaw is terminology-normalized upstream content. |
| src/frontend/scripts/update-samples.ts | Centralizes sample field normalization and guards main() so the module can be imported safely. |
| src/frontend/scripts/update-integrations.ts | Replaces ad-hoc regex normalization with the shared terminology helper. |
| src/frontend/scripts/aspire-terminology.ts | Adds a shared terminology normalizer used by generator scripts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Frontend HTML artifact readyThe latest frontend build uploaded the This comment updates automatically when a new frontend build artifact is uploaded. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: febf329c-97d8-41aa-bd42-43273bc57fe7
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: febf329c-97d8-41aa-bd42-43273bc57fe7
IEvangelist
force-pushed
the
dapine/fix-sample-terminology
branch
from
July 23, 2026 13:32
9bbb307 to
ec1ec43
Compare
IEvangelist
added
the
ci:skip-forbidden-words
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
samples.json.NET Aspireorapp hostThis fixes the sample-update regression visible in #1393.
Tests
pnpm --dir ./src/frontend exec vitest run --config vitest.config.ts tests/unit/update-samples.vitest.test.ts tests/unit/update-integrations.vitest.test.tssamples.jsoncontent from chore: Update integration data and GitHub stats (7/23/26) #1393 through the normalizer (8 deprecated occurrences reduced to 0)