ci: allow forbidden-word check bypass label#1398
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 75803994-3eea-47f7-ae25-92f4314a019b
There was a problem hiding this comment.
Pull request overview
This PR updates the “Forbidden Words” GitHub Actions workflow to allow maintainers to bypass the forbidden-word enforcement by applying a dedicated label, while ensuring the required check re-evaluates when labels change.
Changes:
- Re-triggers the workflow on
labeled/unlabeledPR events so the check status reflects label-based bypass changes immediately. - Adds a
ci:skip-forbidden-wordslabel bypass that skips checkout/scan and exits successfully. - When bypassed, emits an empty
findings.jsonand still uploads the findings artifact so downstream suggestion workflows remain quiet.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Frontend HTML artifact readyThe latest frontend build uploaded the This comment updates automatically when a new frontend build artifact is uploaded. |
JamesNK
left a comment
There was a problem hiding this comment.
Review summary
Workflow source reviewed: microsoft/aspire.dev PR base main through head d7ae23cfc2a51aea97864e09ddabf563d667fa22.
Phase A — Claim verification
No Aspire product or API claims were added. The sole changed file is .github/workflows/forbidden-words.yml, and the label-bypass workflow logic has no correctness, security, or required-check issue requiring changes.
Phase B — Documentation test report
Focus area: Not applicable (workflow-only change)
- Routes exercised: None; no documentation pages or sections changed.
- Critical issues: 0
- Warnings: 0
- Passed checks: Not applicable
- Recommendations: None
- Knowledge gaps: None
The documentation site was not started or built because this PR has no user-facing documentation changes.
Summary
ci:skip-forbidden-wordslabelThis addresses false positives such as the intentional terminology fixtures and matching patterns in #1397.