Skip to content

Repository navigation

ci: repin ci-workflows to v0.36.0 #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 1 commit into from
Oct 4, 2026
Merged

ci: repin ci-workflows to v0.36.0 #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/rules/pr-body-contract.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ web); the advisory comment and label are noise this rule exists to prevent.
The canonical machine-readable convention is
`components/pr-convention-policy/policy.json` in `melodic-software/standards`;
the SHA-pinned ci-workflows `pr-contract` composite (moved to
`pr-require-checks/check-contract` at ci-workflows v0.34.0) that runs as a step
`pr-require-checks/check-contract` at ci-workflows v0.36.0) that runs as a step

@claude claude Bot Oct 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is sync-managed; this edit will be silently reverted and shouldn't be hand-made here.

.claude/rules/pr-body-contract.md is listed as a managed destination path in this same repo's .github/workflows/pr-check-managed-files-hosted.yml (line 41), which watches exactly "the sorted union of every sync target's managed destinations" for hand-edits. Per that workflow's own header (lines 3–18), this file is distributed from melodic-software/standards (components/.../pr-body-contract-rule per the chore: sync standards components (#88) commit, 3842583, that introduced the v0.34.0 wording this PR is now editing), and per ADR-0007: "a managed file is byte-exact with its standards source; the fix path is a standards change, never a downstream edit."

Concretely: this PR's edit here isn't durable. The next standards-sync PR will overwrite this line back to whatever melodic-software/standards currently has — if that source still says v0.34.0, this repin is reverted on the next sync; if the source has already moved on, this hand-edit is redundant. Either way, the three other files this PR correctly updates (pr-automerge-dependabot.yml, pr-require-checks.yml) are genuinely repo-owned (no SYNC-MANAGED FILE banner, not on the guard's path list), so the PR's own claim that "sync-managed callers move separately through the standards repin and sync" is true for those but inconsistently applied here — this file should have been excluded from this PR and the version bump made in the melodic-software/standards component instead.

Note: pr-check-managed-files-hosted is advisory during soak (not aggregated into ci-status), so this won't block the merge, but it is a real process violation worth fixing before merge rather than after a sync silently clobbers it.

inside `ci-status` is the enforcement authority, and its step output is the
statement of record.
2 changes: 1 addition & 1 deletion .github/workflows/pr-automerge-dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ jobs:
permissions:
contents: write # enablePullRequestAutoMerge requires it.
pull-requests: write # Arm or disarm auto-merge on the PR.
uses: melodic-software/ci-workflows/.github/workflows/pr-automerge-dependabot.yml@69e506b7c119517ef1dfc421479232b386b93a52 # v0.35.0
uses: melodic-software/ci-workflows/.github/workflows/pr-automerge-dependabot.yml@fb56986808750d6856c27de78df15e150027b8dc # v0.36.0
with:
runner: ubuntu-24.04
4 changes: 2 additions & 2 deletions .github/workflows/pr-require-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,15 +108,15 @@ jobs:
actions: read
steps:
- name: Check the pull-request contract
uses: melodic-software/ci-workflows/.github/actions/pr-require-checks/check-contract@7446b5165511796b7b0d30b68d341689ebb8de61 # v0.34.0
uses: melodic-software/ci-workflows/.github/actions/pr-require-checks/check-contract@fb56986808750d6856c27de78df15e150027b8dc # v0.36.0
with:
token: ${{ github.token }}
- name: Aggregate lane results
# `!cancelled()` so a failing check-contract step does not skip the
# aggregation: the job still fails on the contract step's exit code, and
# the `ci-lanes` status is on the SHA for the next contract-only run.
if: ${{ !cancelled() }}
uses: melodic-software/ci-workflows/.github/actions/pr-require-checks/aggregate-results@7446b5165511796b7b0d30b68d341689ebb8de61 # v0.34.0
uses: melodic-software/ci-workflows/.github/actions/pr-require-checks/aggregate-results@fb56986808750d6856c27de78df15e150027b8dc # v0.36.0
with:
# At least 60 seconds below this job's `timeout-minutes: 5` (300s), so
# the fail-closed error is what a contract-only run reports at the
Expand Down
Loading