Repository navigation
ci: repin ci-workflows to v0.36.0 - #91
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude finished @kyle-sexton's task in 48s —— View job Security review — no issues found
Skip gate applied: this PR has no security-relevant surface requiring logic/trust-boundary review.
No CRITICAL, IMPORTANT, or SUGGESTION findings. |
|
Claude finished @kyle-sexton's task in 2m 36s —— View job Code review complete
SummaryReviewed the 3 changed files ( 1 finding posted inline, on
The two genuinely repo-owned files — Not independently verified (no network access in this session): that |
|
claude-security-review has reviewed this pull request through 25ae3f8; a later push is reviewed from there. |
| `components/pr-convention-policy/policy.json` in `melodic-software/standards`; | ||
| the SHA-pinned ci-workflows `pr-contract` composite (moved to | ||
| `pr-require-checks/check-contract` at ci-workflows v0.34.0) that runs as a step | ||
| `pr-require-checks/check-contract` at ci-workflows v0.36.0) that runs as a step |
There was a problem hiding this comment.
This file is sync-managed; this edit will be silently reverted and shouldn't be hand-made here.
.claude/rules/pr-body-contract.md is listed as a managed destination path in this same repo's .github/workflows/pr-check-managed-files-hosted.yml (line 41), which watches exactly "the sorted union of every sync target's managed destinations" for hand-edits. Per that workflow's own header (lines 3–18), this file is distributed from melodic-software/standards (components/.../pr-body-contract-rule per the chore: sync standards components (#88) commit, 3842583, that introduced the v0.34.0 wording this PR is now editing), and per ADR-0007: "a managed file is byte-exact with its standards source; the fix path is a standards change, never a downstream edit."
Concretely: this PR's edit here isn't durable. The next standards-sync PR will overwrite this line back to whatever melodic-software/standards currently has — if that source still says v0.34.0, this repin is reverted on the next sync; if the source has already moved on, this hand-edit is redundant. Either way, the three other files this PR correctly updates (pr-automerge-dependabot.yml, pr-require-checks.yml) are genuinely repo-owned (no SYNC-MANAGED FILE banner, not on the guard's path list), so the PR's own claim that "sync-managed callers move separately through the standards repin and sync" is true for those but inconsistently applied here — this file should have been excluded from this PR and the version bump made in the melodic-software/standards component instead.
Note: pr-check-managed-files-hosted is advisory during soak (not aggregated into ci-status), so this won't block the merge, but it is a real process violation worth fixing before merge rather than after a sync silently clobbers it.
|
claude-review has reviewed this pull request through 25ae3f8; a later push is reviewed from there. |
No related issue: Phase 8 step 3 of the org GitHub Actions conventions migration (one ci-workflows version everywhere).
Summary
Repins this repository's repo-owned ci-workflows references to v0.36.0 (
fb56986), so every repo converges on one ci-workflows release. Sync-managed callers move separately through the standards repin and sync.Fix
Repo-owned
uses: melodic-software/ci-workflows/...pins move from v0.34.0 (7446b51) or v0.35.0 (69e506b) tofb56986808750d6856c27de78df15e150027b8dc # v0.36.0. Composite paths moved since v0.34.0 are mapped (comment-hygienetocheck-comment-markers,machine-specific-pathstocheck-machine-paths) where pinned.Verification
fb56986in ci-workflows.actionlinton the changed workflows; the repo's own pin checks where it has them.fb56986merged in chore(runner-policy): approve ci-workflows v0.36.0 contracts standards#697.Related
🤖 Generated with Claude Code