Skip to content

fix: Rename correctly mp reports type #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
duprijil wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: Rename correctly mp reports type #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mapping_workbench/frontend/src/pages/app/mapping-packages/[id]/states/[sid]/view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ const ShaclValidationReport =


const tabs = [
{label: 'Details', value: 'details'},
{label: 'Overview', value: 'details'},

@schivmeister schivmeister Jul 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why details is Overview?

@duprijil duprijil Jul 4, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview is the page with state reports overview, is not details

{label: 'Coverage (XPath)', value: 'xpath'},
{label: 'Correctness (SPARQL)', value: 'sparql'},
{label: 'Compliance (SHACL)', value: 'shacl'},
{label: 'Completeness (SHACL)', value: 'shacl'},

@schivmeister schivmeister Jul 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave SHACL as Compliance.

];

const Page = () => {
Expand Down
2 changes: 1 addition & 1 deletion ...orkbench/frontend/src/sections/app/mapping-package/state/result-summary-coverage-shacl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const ResultSummaryCoverageShacl = ({validationReport, handleChangeTab}) => {
<Stack>
<Typography variant='secondary'>Result summary</Typography>
<Typography fontSize='18'
fontWeight='bold'>Coverage (SHACL)</Typography>
fontWeight='bold'>Completeness (SHACL)</Typography>

@schivmeister schivmeister Jul 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compliance

</Stack>
<Button endIcon={<OpenInNewIcon/>}
onClick={() => handleChangeTab('shacl')}>
Expand Down
2 changes: 1 addition & 1 deletion ...rkbench/frontend/src/sections/app/mapping-package/state/result-summary-coverage-sparql.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const ResultSummaryCoverageSparql = ({validationReport, handleChangeTab}) => {
<Stack>
<Typography variant='secondary'>Result summary</Typography>
<Typography fontSize='18'
fontWeight='bold'>Coverage (SPARQL)</Typography>
fontWeight='bold'>Correctness (SPARQL)</Typography>
</Stack>
<Button endIcon={<OpenInNewIcon/>}
onClick={() => handleChangeTab('sparql')}>
Expand Down
2 changes: 1 addition & 1 deletion ...ng_workbench/frontend/src/sections/app/shacl-validation-report/result-summary-coverage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const Pie = ({data, handleExport}) => {
justifyContent='space-between'>
<Stack>
<Typography fontSize='18'
fontWeight='bold'>Coverage (SHACL)</Typography>
fontWeight='bold'>Completeness (SHACL)</Typography>

@schivmeister schivmeister Jul 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compliance

</Stack>
<ExportButton handleExport={handleExport}/>
</Stack>
Expand Down
2 changes: 1 addition & 1 deletion ...g_workbench/frontend/src/sections/app/sparql-validation-report/result-summary-coverage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const Pie = ({data, handleExport}) => {
justifyContent='space-between'>
<Stack>
<Typography fontSize='18'
fontWeight='bold'>Coverage (SPARQL)</Typography>
fontWeight='bold'>Correctness (SPARQL)</Typography>
</Stack>
<ExportButton handleExport={handleExport}/>
</Stack>
Expand Down