fix: Rename correctly mp reports type - #425
Open
duprijil wants to merge 1 commit into
Open
Conversation
schivmeister
requested changes
Jul 4, 2025
schivmeister
left a comment
schivmeister
left a comment
Contributor
There was a problem hiding this comment.
Thanks but SHACL is still Compliance. Left some other clarification comments.
| {label: 'Coverage (XPath)', value: 'xpath'}, | ||
| {label: 'Correctness (SPARQL)', value: 'sparql'}, | ||
| {label: 'Compliance (SHACL)', value: 'shacl'}, | ||
| {label: 'Completeness (SHACL)', value: 'shacl'}, |
Contributor
There was a problem hiding this comment.
Leave SHACL as Compliance.
| <Typography variant='secondary'>Result summary</Typography> | ||
| <Typography fontSize='18' | ||
| fontWeight='bold'>Coverage (SHACL)</Typography> | ||
| fontWeight='bold'>Completeness (SHACL)</Typography> |
| <Stack> | ||
| <Typography fontSize='18' | ||
| fontWeight='bold'>Coverage (SHACL)</Typography> | ||
| fontWeight='bold'>Completeness (SHACL)</Typography> |
|
|
||
| const tabs = [ | ||
| {label: 'Details', value: 'details'}, | ||
| {label: 'Overview', value: 'details'}, |
Contributor
There was a problem hiding this comment.
Why details is Overview?
Collaborator
Author
There was a problem hiding this comment.
Overview is the page with state reports overview, is not details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename MP report types correctly in MP State reports UI:
Compliance -> Completeness (SHACL)
Details -> Overview
and correct naming in specific report