Skip to content

Harden CI workflows: prevent script injection, pin action to SHA #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
murdercode wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −7
Open

Harden CI workflows: prevent script injection, pin action to SHA #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@ jobs:

- name: Resolve version
id: version
env:
EMULE_VERSION_INPUT: ${{ inputs.emule_version }}
run: |
if [ -n "${{ inputs.emule_version }}" ]; then
VER="${{ inputs.emule_version }}"
if [ -n "$EMULE_VERSION_INPUT" ]; then
VER="$EMULE_VERSION_INPUT"
PRERELEASE=$(gh release view "eMule_v${VER}-community" --repo irwir/eMule \
--json isPrerelease --jq '.isPrerelease')
else
Expand Down Expand Up @@ -74,8 +76,9 @@ jobs:
- name: Check if already released
if: steps.version.outputs.skip != 'true'
id: check
env:
VER: ${{ steps.version.outputs.version }}
run: |
VER="${{ steps.version.outputs.version }}"
if gh release view "v$VER" --repo "$GITHUB_REPOSITORY" &>/dev/null; then
echo "skip=true" >> "$GITHUB_OUTPUT"
echo "Release v$VER already exists — skipping build."
Expand All @@ -90,14 +93,18 @@ jobs:

- name: Build .dmg
if: steps.version.outputs.skip != 'true' && steps.check.outputs.skip == 'false'
run: ./build.sh "${{ steps.version.outputs.version }}"
env:
VER: ${{ steps.version.outputs.version }}
run: ./build.sh "$VER"

- name: Create release
if: steps.version.outputs.skip != 'true' && steps.check.outputs.skip == 'false'
env:
VER: ${{ steps.version.outputs.version }}
PRERELEASE: ${{ steps.version.outputs.prerelease }}
run: |
VER="${{ steps.version.outputs.version }}"
PRERELEASE_FLAG=""
if [ "${{ steps.version.outputs.prerelease }}" = "true" ]; then
if [ "$PRERELEASE" = "true" ]; then
PRERELEASE_FLAG="--prerelease"
fi
gh release create "v$VER" "build/macMule-v${VER}.dmg" \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/keepalive.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ jobs:
permissions:
actions: write
steps:
- uses: liskin/gh-workflow-keepalive@v1
- uses: liskin/gh-workflow-keepalive@f72ff1a1336129f29bf0166c0fd0ca6cf1bcb38c # v1.2.1