Harden CI workflows: prevent script injection, pin action to SHA#1
Open
murdercode wants to merge 1 commit into
Open
Harden CI workflows: prevent script injection, pin action to SHA#1murdercode wants to merge 1 commit into
murdercode wants to merge 1 commit into
Conversation
- build.yml: pass workflow_dispatch input and step outputs through
`env:` instead of interpolating `${{ ... }}` directly into `run`
blocks, so user-supplied values can't break out of the shell string.
- keepalive.yml: pin liskin/gh-workflow-keepalive to a full commit SHA
(v1.2.1) instead of the mutable `v1` tag.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two small CI workflow hardening changes. No functional changes.
build.yml— script injection hardeningworkflow_dispatchinputs and step outputs were interpolated directly as${{ ... }}insiderun:blocks. A value containing shell metacharacters could break out of the string and execute commands in the runner. They now all pass throughenv:and are referenced as quoted shell variables ("$VER"), which the runner treats as data rather than code.keepalive.yml— pin action to SHAliskin/gh-workflow-keepalive@v1(mutable tag) → pinned to the full commit SHAf72ff1a1336129f29bf0166c0fd0ca6cf1bcb38c(v1.2.1). Prevents a re-pointed tag from introducing unreviewed code.Verification
${{ }}interpolation insiderun:blocks.