Skip to content

Add compatibility with gammapy 2.1 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdebony merged 5 commits into from
Apr 3, 2026
Merged

Add compatibility with gammapy 2.1 #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a156d31
Update test and setup for gammapy 2.1 (release candidate)
mdebony Apr 2, 2026
e686d35
Temporary fix
mdebony Apr 2, 2026
2844fdb
Temporary fix
mdebony Apr 2, 2026
00c48a0
Relax norm tolerance
mdebony Apr 2, 2026
827055a
Switch test from 2.1rc1 to 2.1
mdebony Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/python-test-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
fail-fast: false
matrix:
gammapy-version: ["1.1", "1.2", "1.3", "2.0"]
gammapy-version: ["1.1", "1.2", "1.3", "2.0", "2.1"]
python-version: ["3.9", "3.11", "3.12", "3.13"]
exclude:
- gammapy-version: 1.1
Expand All @@ -34,6 +34,8 @@ jobs:
python-version: 3.13
- gammapy-version: 2.0
python-version: 3.9
- gammapy-version: 2.1
python-version: 3.9
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
Expand Down
8 changes: 4 additions & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@
long_description=long_description,
long_description_content_type='text/markdown',
install_requires=[
'gammapy>=1.1,<2.1',
'numpy<2.4',
'scipy<1.17',
'gammapy>=1.1,<2.2',
'numpy<2.5',
'scipy<1.18',
'iminuit>=2.0,<3.0',
'astropy>=4.0,<8.0',
'regions>=0.7,<0.11'
'regions>=0.7,<0.12'
],
package_data={
'baccmod': [
Expand Down
3 changes: 2 additions & 1 deletion test/integration_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ class TestIntegrationClass:
relative_tolerance = 1e-3
#TODO when issue with spatial fit is resolved, need to be lowered
relative_tolerance_fit_method = 5e-2
relative_tolerance_normalisation = 5e-3

@gabemery gabemery Apr 3, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say, instead of the current minimum value to pass the test it may be better to pick a value we are confortable with. It can be this value, or 1%, or 5%...


def _print_model_precision(self, background_model, reference):
mask = reference.data != 0
Expand Down Expand Up @@ -334,4 +335,4 @@ def test_integration_norm_per_run(self):
self._print_model_precision(background_model[id_obs], reference)
assert np.all(np.isclose(background_model[id_obs].data, reference.data,
atol=self.absolute_tolerance,
rtol=self.relative_tolerance))
rtol=self.relative_tolerance_normalisation))
Loading