Add compatibility with gammapy 2.1#75
Merged
Merged
Conversation
gabemery
approved these changes
Apr 3, 2026
gabemery
left a comment
gabemery
left a comment
Collaborator
There was a problem hiding this comment.
My comment is very minor, you can change the value or not it remains approved.
| relative_tolerance = 1e-3 | ||
| #TODO when issue with spatial fit is resolved, need to be lowered | ||
| relative_tolerance_fit_method = 5e-2 | ||
| relative_tolerance_normalisation = 5e-3 |
Collaborator
There was a problem hiding this comment.
I would say, instead of the current minimum value to pass the test it may be better to pick a value we are confortable with. It can be this value, or 1%, or 5%...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently based on the release candidate version to check compatibility. To not merge for now.