fix(shell): clean up onboarding load layout + consolidate feedback CTAs#375
Merged
Conversation
Two testing-session cleanups: 1) Onboarding footer jank — the marketing footer rode up under the short 'Preparing your profile…' loading state (and the loader relied on Tailwind classes that don't exist in this project, so it never filled/centered). - Hide the footer on /profile/create (matches the /auth/ focused-flow rule). - Rebuild the loading state with MUI so it centers and fills the viewport. 2) Too many feedback CTAs — there were three (left of the logo, top-right, and the floating button). Removed both header feedback icons (the left-of-logo one was especially confusing); feedback now lives only in the single floating button (bottom-right). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two cleanups from Marc's testing session.
1) Onboarding "footer at the top" jank
On
/profile/create, the page rendered the marketing footer high up (right under a tiny "Preparing your profile…") and then shoved it down once the wizard loaded.Root cause: (a) no sticky-footer layout, so a short page lets the footer ride up, and (b) the loading state used Tailwind classes (
min-h-screen flex items-center justify-center) — but this project has no Tailwind, so those were dead classes and the loader collapsed to content height.Fix:
/profile/create(same focused-flow rule already used for/auth/).CircularProgress+ centeredBox,minHeight: 100dvh) so it fills and centers.2) Too many "log a bug" CTAs
There were three feedback entry points: left of the logo, top-right of the header, and the floating button. The left-of-logo one was especially confusing.
Fix: removed both header feedback icons. Feedback now lives only in the single floating button (bottom-right) — which also has the
fshortcut + coachmark. (Footer still has a "Feedback" link.)Verification
tsc, eslint, andnpm run buildpass.Note
The dead-Tailwind loading pattern also exists in a couple other spots (e.g. the
/profile/createpage's ownstatus === 'loading'flash). Left out of this PR to keep it focused; happy to sweep them in a follow-up.🤖 Generated with Claude Code