feat(onboarding): single 'complete your card' screen with Cancel / Done#376
Merged
Conversation
Reaching the profile completion from a just-in-time prompt (e.g. Create a library) felt like a confusing multi-step wizard: four ambiguous corner controls (close X, a sign-out icon that reads like 'share', a Back arrow 'to where?', and Continue). Rework it into one focused task: - Merge photo + address into a single 'Complete your card' step (was two). - Exactly two clear actions: a text 'Cancel' and a primary 'Done!' (submits the full profile). Cancel exits to the app when opened from a prompt, otherwise steps back to the minimal entry. - Hide the top close/sign-out icons on the completion step (Cancel covers it). - Wizard is now two steps (basics -> complete); the completeness indicator highlights whichever of photo/address is still outstanding. - Remove the now-orphaned ProfileStep3. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Marc's walkthrough: reaching profile completion from a just-in-time prompt (e.g. Create a library) felt like a confusing multi-step wizard — four ambiguous corner controls: a close X, a sign-out icon that reads like "share," a Back arrow ("to where?"), and Continue. The expectation when something says "wait, I just need this info" is: provide it and hit Done — or Cancel.
Change
ProfileStep3.The full-onboarding path (Step 1 → "Add a photo & address now") lands on the same combined screen, so it benefits too.
Verification
tsc, eslint, unit tests, andnpm run buildall pass.Note
Builds on the still-open #375 (footer/loader + feedback-CTA cleanup) but touches different files — no conflict. Independent of #375's merge order.
🤖 Generated with Claude Code