Skip to content
This repository was archived by the owner on Feb 26, 2019. It is now read-only.

Missing 'width' option check #28

Open
ali997 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Missing 'width' option check #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/farbtastic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ $._farbtastic = function (container, options) {
};

// Parse options.
if (!options.callback) {
if (!options.callback && !options.width) {
options = { callback: options };

@mattfarina mattfarina Apr 30, 2015

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be handled differently. If there is no callback property than one should be defined rather than redefining options.

@ali997 ali997 Apr 30, 2015

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my case i have to initialize script with empty callback, set color and then link to callback. There is no way to set starting color if i don't use input field and i have to initialize with options because you can't set width otherwise. Maybe there should be a color option then?

}
options = $.extend({
Expand Down