This repository was archived by the owner on Feb 26, 2019. It is now read-only.
Missing 'width' option check - #28
Open
ali997 wants to merge 1 commit into
Open
Conversation
Owner
There was a problem hiding this comment.
This should be handled differently. If there is no callback property than one should be defined rather than redefining options.
Author
There was a problem hiding this comment.
In my case i have to initialize script with empty callback, set color and then link to callback. There is no way to set starting color if i don't use input field and i have to initialize with options because you can't set width otherwise. Maybe there should be a color option then?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When 'callback' option was missing script was ignoring 'width' option.
This wont work:
This will:
Proposed fix will work for now but to avoid any future problems i think there should be something like: