Skip to content

MM-26917 update channel header message format #10020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Akanshagore wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MM-26917 update channel header message format #10020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 89 additions & 1 deletion ...omponents/post_list/post/system_message/__snapshots__/system_message_helpers.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,95 @@ exports[`renderSystemMessage uses renderer for Channel Header update 1`] = `
}
testID="markdown_text"
>
updated the channel header from: old header to: new header
updated the channel header
</Text>
<Text
testID="markdown_break"
>


</Text>
<Text
selectable={false}
style={
[
{
"color": "rgba(63,67,80,0.6)",
"fontFamily": "OpenSans",
"fontSize": 16,
"fontWeight": "400",
"lineHeight": 24,
},
[
{
"fontFamily": "OpenSans-SemiBold",
"fontWeight": "600",
},
],
]
}
testID="markdown_text"
>
From:
</Text>
<Text
selectable={false}
style={
{
"color": "rgba(63,67,80,0.6)",
"fontFamily": "OpenSans",
"fontSize": 16,
"fontWeight": "400",
"lineHeight": 24,
}
}
testID="markdown_text"
>
old header
</Text>
<Text
testID="markdown_break"
>


</Text>
<Text
selectable={false}
style={
[
{
"color": "rgba(63,67,80,0.6)",
"fontFamily": "OpenSans",
"fontSize": 16,
"fontWeight": "400",
"lineHeight": 24,
},
[
{
"fontFamily": "OpenSans-SemiBold",
"fontWeight": "600",
},
],
]
}
testID="markdown_text"
>
To:
</Text>
<Text
selectable={false}
style={
{
"color": "rgba(63,67,80,0.6)",
"fontFamily": "OpenSans",
"fontSize": 16,
"fontWeight": "400",
"lineHeight": 24,
}
}
testID="markdown_text"
>
new header
</Text>
</Text>
</View>
Expand Down
2 changes: 1 addition & 1 deletion app/components/post_list/post/system_message/system_message.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ const renderMessage = ({location, post, styles, intl, localeHolder, theme, value
const headerMessages = defineMessages({
updatedFrom: {
id: 'mobile.system_message.update_channel_header_message_and_forget.updated_from',
defaultMessage: '{username} updated the channel header from: {oldHeader} to: {newHeader}',
defaultMessage: '{username} updated the channel header\n**From:** {oldHeader}\n**To:** {newHeader}',
Comment thread
coderabbitai[bot] marked this conversation as resolved.
},
updatedTo: {
id: 'mobile.system_message.update_channel_header_message_and_forget.updated_to',
Expand Down
8 changes: 7 additions & 1 deletion app/components/post_list/post/system_message/system_message_helpers.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,13 @@ describe('renderSystemMessage', () => {
);
expect(toJSON()).toMatchSnapshot();
expect(getByText('@username')).toBeTruthy();
expect(getByText('updated the channel header from: old header to: new header')).toBeTruthy();
expect(getByText('updated the channel header')).toBeTruthy();

expect(getByText('From:')).toBeTruthy();
expect(getByText('old header')).toBeTruthy();

expect(getByText('To:')).toBeTruthy();
expect(getByText('new header')).toBeTruthy();
});

test('uses renderer for Channel Display Name update', () => {
Expand Down
2 changes: 1 addition & 1 deletion assets/base/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,7 +1067,7 @@
"mobile.system_message.channel_unarchived_message": "{username} unarchived the channel",
"mobile.system_message.update_channel_displayname_message_and_forget.updated_from": "{username} updated the channel display name from: {oldDisplayName} to: {newDisplayName}",
"mobile.system_message.update_channel_header_message_and_forget.removed": "{username} removed the channel header (was: {oldHeader})",
"mobile.system_message.update_channel_header_message_and_forget.updated_from": "{username} updated the channel header from: {oldHeader} to: {newHeader}",
"mobile.system_message.update_channel_header_message_and_forget.updated_from": "{username} updated the channel header\n**From:** {oldHeader}\n**To:** {newHeader}",
"mobile.system_message.update_channel_header_message_and_forget.updated_to": "{username} updated the channel header to: {newHeader}",
"mobile.system_message.update_channel_purpose_message.removed": "{username} removed the channel purpose (was: {oldPurpose})",
"mobile.system_message.update_channel_purpose_message.updated_from": "{username} updated the channel purpose from: {oldPurpose} to: {newPurpose}",
Expand Down
Loading