MM-26917 update channel header message format - #10020
Conversation
|
Hello @Akanshagore, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
📝 WalkthroughWalkthroughThe channel-header system message now displays the previous and new headers on separate labelled lines. The labels use Markdown emphasis. ChangesChannel Header Formatting
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/components/post_list/post/system_message/system_message.tsx`:
- Line 94: Update the renderer test covering the channel-header system message
in the system message helpers test to expect the new separate “From” and “To”
lines, and refresh its snapshot to match the updated defaultMessage format.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 506e8f93-20a1-4458-a745-0153803a2536
📒 Files selected for processing (1)
app/components/post_list/post/system_message/system_message.tsx
62bd69e to
29eabc9
Compare
|
/check-cla |
|
Hi team, the requested changes have been addressed and CodeRabbit has approved the PR. CLA is also authorized. Could a maintainer please review and approve when available, and approve the pending workflows if needed? This would help unblock the merge. Thanks! |
|
Hi team, just following up on this PR as it’s been a week since my last update. The requested changes have been addressed, CodeRabbit has approved the PR, and the CLA is authorized. The remaining workflows are still awaiting maintainer approval, and the PR is also waiting for the required reviews. Whenever someone has a chance, could you please take a look and help unblock the PR? Thanks! |
|
Hi team, just following up on this PR. The requested changes have been addressed, CodeRabbit has approved the changes, and the CLA is authorized. At the moment, the PR is only blocked on the required maintainer reviews and the pending workflow approvals. When someone gets a chance, could you please review the PR and approve the pending workflows? It would be really helpful in getting this PR unblocked. Thanks for your time and support! |
|
The jira ticket referenced here dosn't seem like the right one @Akanshagore. Could you share the correct Jira ticket and update the PR description? |
matthewbirtch
left a comment
There was a problem hiding this comment.
Thanks for this @Akanshagore. Looks good to me.
Willyfrog
left a comment
There was a problem hiding this comment.
HI @Akanshagore thanks a lot for contributing. I'd like to address some issues more related to our PR process than to the code itself:
- Can you update to the right ticket? MM-26917 is not related to your change
- Can you add a screenshot that shows the change you have implemented?
Summary
Updated the channel header system message format to show the changes in a clearer From/To format.
Changes
assets/base/i18n/en.json.Ticket
MM-26917
Testing
Run:
npx jest app/components/post_list/post/system_message/system_message_helpers.test.js -u
Result:
9 tests passed.
Checklist
E2E/Run(orE2E/Run-iOS/E2E/Run-Androidfor platform-specific runs).Device Information
This PR was tested on: Not tested
Screenshots
N/A
Release Note