Skip to content

Workbench Browser workflow convergence #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masarray merged 1 commit into from
Oct 14, 2026
Merged

Workbench Browser workflow convergence #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ied-simulator-qt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,18 +132,19 @@ jobs:
QT_QPA_PLATFORM: offscreen
run: ./build-ied-simulator-qt/ied_product_hardening_qa

- name: IEDScout-style File/Home workflow contract
- name: File/Home workflow contract
run: >-
python3 apps/ied_simulator/test_file_home_workflow.py
apps/ied_simulator/qml/FileWorkspace.qml
apps/ied_simulator/qml/Main.qml

- name: IEDScout-style Browser convergence contract
- name: Browser convergence contract
run: >-
python3 apps/ied_simulator/test_browser_convergence.py
apps/ied_simulator/qml/IedBrowserWorkspace.qml
apps/ied_simulator/qml/IedBrowserNavigation.qml
apps/ied_simulator/qml/BrowserStatusConsole.qml
apps/ied_simulator/qml/BrowserDataModelPane.qml

- name: Canonical Browser service reuse contract
run: >-
Expand Down
1 change: 1 addition & 0 deletions apps/ied_simulator/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ qt_add_qml_module(arstack_ied_simulator
qml/IedBrowserWorkspace.qml
qml/IedBrowserNavigation.qml
qml/BrowserStatusConsole.qml
qml/BrowserDataModelPane.qml
qml/BrowserDataSetPane.qml
qml/BrowserGoosePane.qml
qml/BrowserGlobalDataPane.qml
Expand Down
38 changes: 38 additions & 0 deletions apps/ied_simulator/design-qa.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# IED Browser workflow visual QA

Date: 2026-10-14
Result: PASS

## Scope

The Browser presentation was compared against eight user-provided commercial-tool screenshots. The implementation reproduces the useful interaction model and information hierarchy without copying vendor branding, trademarks, icons, or packaged assets.

## Verified states

- Browser shell with a compact grouped ribbon for application, endpoint, session, data, and service actions.
- Persistent dark engineering explorer with one active canonical IED context.
- Data Model hierarchy with LD, LN, DO, and DA rows.
- Dense right-pane Data Model projection with bounded direct-child rows, Back navigation, and double-click drill-down using the canonical tree.
- DataSet overview-to-member drill-down with live values resolved from the same canonical model when available.
- Reports inventory with URCB/BRCB identity, domain, logical node, selection, and contextual actions.
- RCB detail as a dense property grid, with explicit engineering/runtime evidence state.
- Received-report rows with bounded expandable value lists.
- GOOSE overview and item drill-down with control-block, addressing, VLAN, timing, and DataSet-member details.
- DataSets, Files, Setting Groups, Global Data, status history, and multi-IED tabs remain reachable.

## Intentional product differences

- ARStack identity and the existing teal/graphite design system are retained.
- Multi-IED workspace tabs remain because they are an ARStack capability.
- Unsupported or unavailable live values render as unknown (`—`); the UI does not invent false/default protocol state.
- Engineering-model GOOSE evidence remains distinct from live Ethernet capture and publication.
- Report activation remains gated by a live association; an offline SCL view does not pretend that an RCB is enabled.

## Evidence reviewed

- Side-by-side RCB detail comparison: hierarchy, grouped commands, property-grid density, report-data region, and status placement.
- Side-by-side GOOSE detail comparison: explorer drill-down, breadcrumb, attribute table, and DataSet members.
- Native rendered screenshots completed with no changed-pane QML runtime diagnostics on stderr; pre-existing diagnostics in unrelated dialogs/workspaces remain outside this change.
- Final Data Model render retained as local QA evidence outside the repository.
- The 60,106-node large-model gate remained within bounds after the presentation changes.

292 changes: 292 additions & 0 deletions apps/ied_simulator/qml/BrowserDataModelPane.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,292 @@
// SPDX-License-Identifier: GPL-3.0-or-later
import QtQuick
import QtQuick.Controls
import QtQuick.Layouts

Rectangle {
id: root

required property var theme
required property var client
required property var modelProvider

readonly property var treeModel: modelProvider.treeModel
readonly property var currentNode: treeModel.presentationNode
property int highlightedRow: -1

color: theme.background

function text(value) {
return value === undefined || value === null || String(value).length === 0
? "—" : String(value)
}

function drillInto(row) {
if (!treeModel.selectChild(row))
return
highlightedRow = -1
if (treeModel.presentationNode.hasChildren !== true
&& client.connected && !client.operationBusy
&& treeModel.presentationNode.readable === true)
client.readEngineeringSelected()
}

Connections {
target: root.treeModel
function onSelectionChanged() { root.highlightedRow = -1 }
}

ColumnLayout {
anchors.fill: parent
spacing: 0

Rectangle {
Layout.fillWidth: true
Layout.preferredHeight: 30
color: theme.surface
border.width: 1
border.color: theme.lineSoft

RowLayout {
anchors.fill: parent
anchors.leftMargin: 8
anchors.rightMargin: 8
spacing: 7

Button {
objectName: "browserDataModelBack"
visible: Boolean(root.currentNode.kind) && root.currentNode.kind !== "IED"
implicitWidth: 24
implicitHeight: 22
text: "‹"
onClicked: root.treeModel.selectParent()
ToolTip.visible: hovered
ToolTip.text: "Up one model level"
}

Rectangle {
implicitWidth: Math.max(24, nodeKind.implicitWidth + 10)
implicitHeight: 18
radius: 2
color: theme.accent
Label {
id: nodeKind
anchors.centerIn: parent
text: root.currentNode.kind || "MODEL"
color: "#ffffff"
font.pixelSize: 7
font.weight: Font.Bold
}
}

Label {
Layout.fillWidth: true
text: root.currentNode.label || "Data Model"
color: theme.text
font.pixelSize: 10
font.weight: Font.DemiBold
elide: Text.ElideMiddle
}

Label {
visible: root.treeModel.selectedChildCount > 0
text: root.treeModel.selectedChildCount + " item(s)"
color: theme.muted
font.pixelSize: 8
}
}
}

Rectangle {
visible: root.treeModel.selectedChildCount > 0
Layout.fillWidth: true
Layout.preferredHeight: 25
color: theme.chrome
border.width: 1
border.color: theme.lineSoft

RowLayout {
anchors.fill: parent
anchors.leftMargin: 8
anchors.rightMargin: 8
spacing: 8
Label {
Layout.fillWidth: true
text: "Name"
color: theme.textSoft
font.pixelSize: 8
font.weight: Font.DemiBold
}
Label {
Layout.preferredWidth: Math.max(180, root.width * 0.42)
text: "Value / description"
color: theme.textSoft
font.pixelSize: 8
font.weight: Font.DemiBold
}
}
}

ListView {
id: childList
objectName: "browserDataModelChildren"
visible: root.treeModel.selectedChildCount > 0
Layout.fillWidth: true
Layout.fillHeight: true
clip: true
reuseItems: true
cacheBuffer: 0
model: root.treeModel.selectedChildren
ScrollBar.vertical: ScrollBar {}

delegate: Rectangle {
id: childRow
required property int index
required property var modelData
width: childList.width
height: 25
color: root.highlightedRow === index ? theme.accent
: childMouse.containsMouse ? theme.accentSoft
: index % 2 ? theme.surfaceSoft : theme.surface
border.width: 1
border.color: theme.lineSoft

RowLayout {
anchors.fill: parent
anchors.leftMargin: 7
anchors.rightMargin: 7
spacing: 6

Label {
Layout.preferredWidth: 10
text: childRow.modelData.hasChildren === true ? "›" : ""
color: root.highlightedRow === childRow.index ? "#ffffff" : theme.muted
font.pixelSize: 9
}
Rectangle {
Layout.preferredWidth: 20
Layout.preferredHeight: 17
radius: 2
color: root.highlightedRow === childRow.index ? "#ffffff" : theme.accent
Label {
anchors.centerIn: parent
text: childRow.modelData.kind || ""
color: root.highlightedRow === childRow.index ? theme.accent : "#ffffff"
font.pixelSize: 7
font.weight: Font.Bold
}
}
Label {
Layout.fillWidth: true
text: childRow.modelData.label || childRow.modelData.reference || "—"
color: root.highlightedRow === childRow.index ? "#ffffff" : theme.text
font.pixelSize: 9
elide: Text.ElideMiddle
}
Label {
visible: childRow.modelData.functionalConstraint
&& String(childRow.modelData.functionalConstraint).length > 0
text: "[" + childRow.modelData.functionalConstraint + "]"
color: root.highlightedRow === childRow.index ? "#dff7f3" : theme.muted
font.pixelSize: 8
}
Label {
Layout.preferredWidth: Math.max(180, root.width * 0.42)
text: childRow.modelData.value
|| childRow.modelData.description
|| (childRow.modelData.childCount > 0
? childRow.modelData.childCount + " item(s)" : "—")
color: root.highlightedRow === childRow.index ? "#ffffff" : theme.textSoft
font.pixelSize: 9
elide: Text.ElideRight
}
}

MouseArea {
id: childMouse
anchors.fill: parent
hoverEnabled: true
onClicked: root.highlightedRow = childRow.index
onDoubleClicked: root.drillInto(childRow.index)
}
}
}

ScrollView {
visible: root.treeModel.selectedChildCount === 0
Layout.fillWidth: true
Layout.fillHeight: true
contentWidth: availableWidth

ColumnLayout {
width: Math.max(0, parent.width - 24)
x: 12
spacing: 0

Repeater {
model: [
{label: "Reference", value: root.currentNode.reference},
{label: "Value", value: root.currentNode.value},
{label: "Quality", value: root.currentNode.quality},
{label: "Timestamp", value: root.currentNode.timestamp},
{label: "Functional constraint", value: root.currentNode.functionalConstraint},
{label: "MMS type", value: root.currentNode.mmsType},
{label: "SCL type", value: root.currentNode.sclType},
{label: "Type evidence", value: root.currentNode.typeStatus}
]
delegate: Rectangle {
required property int index
required property var modelData
visible: modelData.value !== undefined && modelData.value !== null
&& String(modelData.value).length > 0
Layout.fillWidth: true
Layout.preferredHeight: visible ? 27 : 0
color: index % 2 ? theme.surfaceSoft : theme.surface
border.width: 1
border.color: theme.lineSoft
RowLayout {
anchors.fill: parent
anchors.leftMargin: 8
anchors.rightMargin: 8
Label {
Layout.preferredWidth: Math.max(150, root.width * 0.34)
text: modelData.label
color: theme.muted
font.pixelSize: 8
}
Label {
Layout.fillWidth: true
text: root.text(modelData.value)
color: theme.text
font.pixelSize: 9
elide: Text.ElideMiddle
}
}
}
}

Label {
visible: !root.currentNode.kind
Layout.fillWidth: true
Layout.topMargin: 32
text: "No canonical model is loaded."
horizontalAlignment: Text.AlignHCenter
color: theme.muted
font.pixelSize: 10
}
Item { Layout.fillHeight: true }
}
}

Label {
visible: root.treeModel.selectedChildrenTruncated
Layout.fillWidth: true
Layout.preferredHeight: 24
text: "Showing the first 4096 direct children. Refine the canonical tree selection to continue."
color: theme.amber
font.pixelSize: 8
horizontalAlignment: Text.AlignHCenter
verticalAlignment: Text.AlignVCenter
}
}
}
Loading
Loading