Repository navigation
P3-H P0: centralize Process Bus VLAN invariants - #140
Merged
Merged
Conversation
Use one IEEE 802.1Q wire invariant for VID/PCP validation, reject reserved VID 4095 before deployment/encoding, preserve priority-tagged VID 0 where generic Ethernet permits it, and add SV/SCL/PTP boundary regressions. Tracks #139.
This was referenced Oct 6, 2026
masarray
marked this pull request as ready for review
October 6, 2026 12:43
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks #139. Continues #24 / #33 / #36 from exact main baseline
c7238d3a8ff86b30b397164c5fcbed820562b3e0.Why
The core Ethernet encoder already rejects IEEE 802.1Q VID 4095, but several upstream SV/Studio/embedded gates accepted it. That allowed an invalid profile to survive configuration/deployment validation and fail only when the frame/template reached the encoder. The generic PTP Ethernet builder had the same off-by-one inconsistency.
This PR removes that split authority.
Architecture
Regression coverage
Multi-thread / recovery boundary
This is only P0 of #139. Do not fold P0.1 WirePlan, multi-ASDU, IEC 61869-9 profile expansion, scaling, PRP/HSR or admission planning into this PR.
Next node after this PR is accepted: P0.1 deterministic encoder-produced WirePlan/patch metadata, replacing
find_fixed_field()without adding a second BER parser.Merge gate
Keep Draft until exact-head required CI is green. Physical bench evidence is not required for this pure validation invariant change, but no product/release conformance claim is made by this PR.