Skip to content

fix(ci): upload example assets only for releases #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mrousavy wants to merge 1 commit into
base: perf/cleanup-ci
Choose a base branch
from
Draft

fix(ci): upload example assets only for releases #1608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions .github/workflows/build-android-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ jobs:
build_release:
name: Build Android Example App (release, new architecture)
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- uses: actions/checkout@v7
- uses: oven-sh/setup-bun@v2
Expand All @@ -34,14 +36,14 @@ jobs:
./gradlew clean :app:assembleRelease --no-daemon --no-build-cache

- name: Upload APK to Release
uses: actions/upload-release-asset@v1
if: github.event_name == 'release'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ github.event.release.upload_url }}
asset_path: apps/example/android/app/build/outputs/apk/release/app-release.apk
asset_name: "NitroExample-${{ github.event.release.tag_name }}.apk"
asset_content_type: application/vnd.android.package-archive
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
RELEASE_TAG: ${{ github.event.release.tag_name }}
run: |
ASSET_NAME="NitroExample-${RELEASE_TAG}.apk"
mv apps/example/android/app/build/outputs/apk/release/app-release.apk "$ASSET_NAME"
gh release upload "$RELEASE_TAG" "$ASSET_NAME" --repo "$GITHUB_REPOSITORY"

# Gradle cache doesn't like daemons
- name: Stop Gradle Daemon
Expand Down
16 changes: 9 additions & 7 deletions .github/workflows/build-ios-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ jobs:
build_release:
name: Build iOS Example App (release, new architecture)
runs-on: macos-26
permissions:
contents: write
steps:
- uses: actions/checkout@v7
- uses: oven-sh/setup-bun@v2
Expand Down Expand Up @@ -54,11 +56,11 @@ jobs:
zip -r "$GITHUB_WORKSPACE/NitroExample-Release-Simulator.zip" NitroExample.app

- name: Upload .app to Release
uses: actions/upload-release-asset@v1
if: github.event_name == 'release'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ github.event.release.upload_url }}
asset_path: NitroExample-Release-Simulator.zip
asset_name: "NitroExample-Simulator-${{ github.event.release.tag_name }}.app.zip"
asset_content_type: application/zip
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
RELEASE_TAG: ${{ github.event.release.tag_name }}
run: |
ASSET_NAME="NitroExample-Simulator-${RELEASE_TAG}.app.zip"
mv NitroExample-Release-Simulator.zip "$ASSET_NAME"
gh release upload "$RELEASE_TAG" "$ASSET_NAME" --repo "$GITHUB_REPOSITORY"
Loading